Re: [libcxx] r294107 - Recommit [libcxx] Never use within libc++

2017-02-07 Thread Eric Fiselier via cfe-commits
Hi Jonas, I fixed the filesystem test failures in r294360. You should be able to re-enable LIBCXX_ENABLE_ASSERTIONS. /Eric On Mon, Feb 6, 2017 at 3:25 AM, Eric Fiselier wrote: > I should have made it more clear that this change actually caused 100's of > assertions to be turned on. And good ne

Re: [libcxx] r294107 - Recommit [libcxx] Never use within libc++

2017-02-06 Thread Eric Fiselier via cfe-commits
I should have made it more clear that this change actually caused 100's of assertions to be turned on. And good news! They found bugs! On initial inspection in appears that the new path parser implementation has some issues. I'll work on fixing them in the coming days. After I commit the fixes I'll

RE: [libcxx] r294107 - Recommit [libcxx] Never use within libc++

2017-02-06 Thread Hahnfeld, Jonas via cfe-commits
Hi Eric, I'm getting quite a few failures with LIBCXX_ENABLE_ASSERTIONS=On (didn't do a clean build at first): Failing Tests (32): libc++ :: std/experimental/filesystem/class.directory_entry/directory_entry.cons.pass.cpp libc++ :: std/experimental/filesystem/class.directory_entry/direct