joerg added a comment.
I had a long discussion with James about this on IRC without reaching a clear
consensus. I consider forcing this behavior on all targets to be a major bug.
It should be opt-in and opt-in only:
(1) The header name is not mandated by any standard. It is not in any namespa
fedor.sergeev added inline comments.
Comment at: test/Driver/stdc-predef.c:15
+ /* In this test, the file stdc-predef.h is missing from the
+installation */ #if _STDC_PREDEF_H
+ #error "stdc-predef.h should not be included"
I would rather see a real check on
On Fri, Jul 28, 2017 at 02:07:29PM +, Blower, Melanie wrote:
>
>
> fedor.sergeev added a comment.
>
> Hmm... I tried this patch and now the following worries me:
>
> - it passes -finclude-if-exists stdc-predef.h on all platforms (say,
> including my Solaris platform that has no system std
jyknight added a comment.
In https://reviews.llvm.org/D34158#823316, @fedor.sergeev wrote:
> Hmm... I tried this patch and now the following worries me:
>
> - it passes -finclude-if-exists stdc-predef.h on all platforms (say,
> including my Solaris platform that has no system stdc-predef.h)
fedor.sergeev added a comment.
Hmm... I tried this patch and now the following worries me:
- it passes -finclude-if-exists stdc-predef.h on all platforms (say, including
my Solaris platform that has no system stdc-predef.h)
- it searches all the paths, not just "system include" ones
That ess
@jyknight I've removed the check on nostdinc. AFAIK, I've addressed all the
feedback which I've received on the patch, is it OK to commit? --Melanie
-Original Message-
From: James Y Knight via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: Monday, July 10, 2017 11:57 AM
To: Blower
