[PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

shafik added a comment. Herald added a project: All. Should we close this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23602/new/ https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

djasper accepted this revision. djasper added a comment. Looks good. Repository: rL LLVM https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. This lgtm. I haven't touched clang-format before, so it would be good to double-check with the code owner before committing. Repository: rL LLVM https://reviews.llvm.o

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs set the repository for this revision to rL LLVM. abergmeier-dsfishlabs updated this revision to Diff 68488. abergmeier-dsfishlabs added a comment. Proper patch of last version (hopefully) Repository: rL LLVM https://reviews.llvm.org/D23602 Files: tools/clang-format/gi

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs removed rL LLVM as the repository for this revision. abergmeier-dsfishlabs updated this revision to Diff 68487. abergmeier-dsfishlabs added a comment. Removed unnecessary list conversion. https://reviews.llvm.org/D23602 Files: tools/clang-format/git-clang-format Index:

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

vsk added a subscriber: vsk. Comment at: tools/clang-format/git-clang-format:303 @@ -300,3 +302,3 @@ allowed_extensions = frozenset(allowed_extensions) - for filename in dictionary.keys(): + for filename in list(dictionary.keys()): base_ext = filename.rsplit('.', 1)

[PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs created this revision. abergmeier-dsfishlabs added a reviewer: djasper. abergmeier-dsfishlabs added a subscriber: cfe-commits. abergmeier-dsfishlabs set the repository for this revision to rL LLVM. abergmeier-dsfishlabs changed the edit policy of this Differential Revision fr

Port tools/clang-format/git-clang-format to work Python beyond 2.7

Since Python3 may deliberately not be available on Linux Systems (to prevent people from writing non-futureproof code), git-clang-format should not only work with Python2.7. This patch adds support for Python3. From 20175b753d8ef9f00f33fe04484dce1c0148ff7c Mon Sep 17 00:00:00 2001 From: Andreas