[PATCH] D38717: Patch to Bugzilla 31373

2017-10-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Please make sure the title (subject line) for a patch reflects the actual contents of the change, as opposed to referring to Bugzilla; a lot of people skim cfe-commits, so you want to make sure interested reviewers find you patch. Needs a regression test to verify we g

[PATCH] D38717: Patch to Bugzilla 31373

2017-10-10 Thread Erik Viktorsson via Phabricator via cfe-commits
erikv created this revision. Committing a patch to Bugzilla 31373 A novice programmer so hopefully it complies with the coding policy. I had to disable an assert in lib/CodeGen/CGExpr.cpp since it requires that all expressions are marked as Used or referenced, which is not possible if we want

Re: Patch to Bugzilla 31373

2017-10-09 Thread Chad Rosier via cfe-commits
Hi Erik, You might consider posting your patch to Phabricator.  You'll likely get more feedback/traction there.. https://llvm.org/docs/Phabricator.html  Chad On 10/6/2017 8:15 AM, Erik Viktorsson via cfe-commits wrote: Committing a patch to Bugzilla 31373 <https://bugs.

Re: Patch to Bugzilla 31373

2017-10-06 Thread Roman Lebedev via cfe-commits
On Fri, Oct 6, 2017 at 3:15 PM, Erik Viktorsson via cfe-commits wrote: Hi. > Committing a patch to Bugzilla 31373 > > A novice programmer so hopefully it complies with the coding policy. I think it may be better to put it to Phabricator, see https://llvm.org/docs/Phabricator.html#id3

Patch to Bugzilla 31373

2017-10-06 Thread Erik Viktorsson via cfe-commits
Committing a patch to Bugzilla 31373<https://bugs.llvm.org/show_bug.cgi?id=31373> A novice programmer so hopefully it complies with the coding policy. I had to disable an assert in lib/CodeGen/CGExpr.cpp since it requires that all expressions are marked as Used or referenced, which