Re: Fwd: r198063 - Warn on mismatched parentheses in memcmp and friends.

2016-10-18 Thread Richard Smith via cfe-commits
On Tue, Oct 18, 2016 at 9:31 AM, Nico Weber wrote: > Did you find real-world code triggering this, or did you happen to see the > implementation of the warning? I'm not sure if omitting just the note or > the whole warning is more useful in practice. Intuitively I'd say that > people "never" will

Re: Fwd: r198063 - Warn on mismatched parentheses in memcmp and friends.

2016-10-18 Thread Nico Weber via cfe-commits
Did you find real-world code triggering this, or did you happen to see the implementation of the warning? I'm not sure if omitting just the note or the whole warning is more useful in practice. Intuitively I'd say that people "never" will compare the result of memcpy, so I'd guess that it doesn't m

Fwd: r198063 - Warn on mismatched parentheses in memcmp and friends.

2016-10-17 Thread Richard Smith via cfe-commits
[Re-send to correct addresses.] On Thu, Dec 26, 2013 at 3:38 PM, Nico Weber wrote: > Author: nico > Date: Thu Dec 26 17:38:39 2013 > New Revision: 198063 > > URL: http://llvm.org/viewvc/llvm-project?rev=198063&view=rev > Log: > Warn on mismatched parentheses in memcmp and friends. > > Thisadds a