Re: [libunwind] r284125 - [libunwind] Add missing include. NFC.

2016-10-13 Thread Asiri Rathnayake via cfe-commits
Had a look at the C99 spec, according to section 7.18.1.1 ("Exact-width integer types"), the types uint_t should be available in stdint.h itself, inttypes.h on the other hand builds on stdint.h and provides more functionality. I don't see a particular need to include inttypes.h here? Cheers, / A

Re: [libunwind] r284125 - [libunwind] Add missing include. NFC.

2016-10-13 Thread Joerg Sonnenberger via cfe-commits
On Thu, Oct 13, 2016 at 02:32:24PM -, Asiri Rathnayake via cfe-commits wrote: > This missing include seems to cause compilation failures on older MacOS > versions (< 10.9). This is because r270692 has introduced uint64_t into > config.h without including this header. But that would be inttype

[libunwind] r284125 - [libunwind] Add missing include. NFC.

2016-10-13 Thread Asiri Rathnayake via cfe-commits
Author: asiri Date: Thu Oct 13 09:32:24 2016 New Revision: 284125 URL: http://llvm.org/viewvc/llvm-project?rev=284125&view=rev Log: [libunwind] Add missing include. NFC. This missing include seems to cause compilation failures on older MacOS versions (< 10.9). This is because r270692 has introdu