[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/85097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

al45tair wrote: I don't have merge rights here, so someone else will need to hit the Merge button. https://github.com/llvm/llvm-project/pull/85097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/85097 >From 6808d20b198bba4f2e062094b89cfc13eac49f85 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Thu, 22 Feb 2024 11:59:24 + Subject: [PATCH 1/3] [libunwind] Tweak tests for musl support. We can't use

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -24,16 +23,30 @@ #include #include +// Note: this test fails on musl because: +// +// (a) musl disables emission of unwind information for its build, and +// (b) musl's signal trampolines don't include unwind information +// al45tair wrote: We'll use `

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -24,16 +23,30 @@ #include #include +// Note: this test fails on musl because: +// +// (a) musl disables emission of unwind information for its build, and +// (b) musl's signal trampolines don't include unwind information +// al45tair wrote: Let's rearr

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -24,16 +23,30 @@ #include #include +// Note: this test fails on musl because: +// +// (a) musl disables emission of unwind information for its build, and +// (b) musl's signal trampolines don't include unwind information +// ldionne wrote: This comment

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -24,16 +23,30 @@ #include #include +// Note: this test fails on musl because: +// +// (a) musl disables emission of unwind information for its build, and +// (b) musl's signal trampolines don't include unwind information +// ldionne wrote: Same here.

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -11,20 +11,27 @@ // Basic test for float registers number are accepted. -#include #include #include #include +// Using __attribute__((section("main_func"))) is Linux specific, but then al45tair wrote: Fair point. https://github.com/llvm/llvm-pro

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -11,20 +11,27 @@ // Basic test for float registers number are accepted. -#include #include #include #include +// Using __attribute__((section("main_func"))) is Linux specific, but then arichardson wrote: Nit: This is not specific to Linux it is s

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/85097 >From 6808d20b198bba4f2e062094b89cfc13eac49f85 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Thu, 22 Feb 2024 11:59:24 + Subject: [PATCH 1/2] [libunwind] Tweak tests for musl support. We can't use

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 960b4aa6dab69125778f230c4c94f2d19c96cc87 6808d20b198bba4f2e062094b89cfc13eac49f85 --

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Alastair Houghton (al45tair) Changes We can't use `dladdr()` in the tests, because when we're statically linking with musl that function is a no-op. Additionally, because musl disables emission of unwind information in its build, and

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

al45tair wrote: This is a cherry pick of https://github.com/apple/llvm-project/pull/8260. https://github.com/llvm/llvm-project/pull/85097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

https://github.com/al45tair created https://github.com/llvm/llvm-project/pull/85097 We can't use `dladdr()` in the tests, because when we're statically linking with musl that function is a no-op. Additionally, because musl disables emission of unwind information in its build, and because its