aheejin wrote:
Hmm, yes, I thought we didn't build `libunwind.cpp` because the code next to
the part I excluded was wrapped with `#ifdef __APPLE__`:
https://github.com/llvm/llvm-project/blob/a8ac930b99d93b2a539ada7e566993d148899144/libunwind/src/libunwind.cpp#L352-L432
But yeah then we build th
arichardson wrote:
> > The commit message is slightly misleading, it appears there are some parts
> > of the file that are actually used?
>
> As the commit message says, we only use
> https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unwind-wasm.c
> and not libunwind.cpp. We don't
aheejin wrote:
> The commit message is slightly misleading, it appears there are some parts of
> the file that are actually used?
As the commit message says, we only use
https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unwind-wasm.c and
not libunwind.cpp. We don't use any parts of
arichardson wrote:
> The commit message is slightly misleading, it appears there are some parts of
> the file that are actually used?
Other than this, the change looks good to me.
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailin
https://github.com/arichardson requested changes to this pull request.
The commit message is slightly misleading, it appears there are some parts of
the file that are actually used?
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits maili
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Author: Heejin Ahn (aheejin)
Changes
Wasm doesn't use that file; Wasm does not allow access of system registers and
those functionalities are provided from the VM. Wasm only uses
https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unw
https://github.com/aheejin created
https://github.com/llvm/llvm-project/pull/73196
Wasm doesn't use that file; Wasm does not allow access of system registers and
those functionalities are provided from the VM. Wasm only uses
https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unwind-wa
