Re: [libcxx] r296919 - Fix hash requirements check in __hash_table.

2017-03-03 Thread Eric Fiselier via cfe-commits
On Fri, Mar 3, 2017 at 4:01 PM, Nico Weber wrote: > "the specified hash does not meet the Hash requirements" isn't a very > actionable diagnostic. > True, For now I was only trying to out-diagnose template barf when I wrote it initially. So in that regard it's a bit more actionable that it was,

Re: [libcxx] r296919 - Fix hash requirements check in __hash_table.

2017-03-03 Thread Nico Weber via cfe-commits
"the specified hash does not meet the Hash requirements" isn't a very actionable diagnostic. Is it possible to use some warning text that lets people know what they need to do to make the compiler happy, instead of just telling them that the compiler is unhappy? On Fri, Mar 3, 2017 at 5:35 PM, Eri

[libcxx] r296919 - Fix hash requirements check in __hash_table.

2017-03-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 3 16:35:58 2017 New Revision: 296919 URL: http://llvm.org/viewvc/llvm-project?rev=296919&view=rev Log: Fix hash requirements check in __hash_table. r296565 attempted to add better diagnostics when an unordered container is instantiated with a hash that doesn't meet t