Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

2017-01-13 Thread Shoaib Meenai via cfe-commits
@lists.llvm.org" Subject: Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl On Thu, Jan 12, 2017 at 1:17 AM, Shoaib Meenai mailto:smee...@fb.com>> wrote: What was the rationale for forcing the use of lld? Were errors encountered with link? It's slightly annoyi

Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

2017-01-13 Thread Eric Fiselier via cfe-commits
On Thu, Jan 12, 2017 at 1:17 AM, Shoaib Meenai wrote: > What was the rationale for forcing the use of lld? Were errors encountered > with link? It's slightly annoying to have the extra dependency; Initially I thought it was required in order to avoid re-writing all of the linker flags. However

Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

2017-01-12 Thread Shoaib Meenai via cfe-commits
What was the rationale for forcing the use of lld? Were errors encountered with link? It's slightly annoying to have the extra dependency; I don't have lld built on my Windows box, for example, and while I could do so, I've also found link to work fine in my testing. On 1/4/17, 7:57 PM, "cfe-commi

[libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

2017-01-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 4 21:57:40 2017 New Revision: 291072 URL: http://llvm.org/viewvc/llvm-project?rev=291072&view=rev Log: Get test-suite configuring on Windows with clang-cl This patch gets the test suite "working" on Windows, although none of the tests pass. In order to reuse the exi