Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Eric Fiselier via cfe-commits
Thanks Richard. I've fixed the tests in r284289. On Fri, Oct 14, 2016 at 4:40 PM, Richard Smith wrote: > On Fri, Oct 14, 2016 at 3:34 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Oh, I have another idea: could it be that you're also turning some >> optimization o

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Richard Smith via cfe-commits
On Fri, Oct 14, 2016 at 3:34 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Oh, I have another idea: could it be that you're also turning some > optimization on when UBSan is enabled? Note that the operator new/operator > delete pair is elidable in each of these tests, an

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Eric Fiselier via cfe-commits
Oh, I have another idea: could it be that you're also turning some optimization on when UBSan is enabled? Note that the operator new/operator delete pair is elidable in each of these tests, and Clang will remove the calls when compiling with optimizations enabled. That's it. The UBSAN tests build

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Richard Smith via cfe-commits
Oh, I have another idea: could it be that you're also turning some optimization on when UBSan is enabled? Note that the operator new/operator delete pair is elidable in each of these tests, and Clang will remove the calls when compiling with optimizations enabled. On Fri, Oct 14, 2016 at 2:38 PM,

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Eric Fiselier via cfe-commits
UBSAN may not be replacing the function, but it is doing something weird at the codegen level. I looked into this a while ago but never sorted it out. Either way I'll clarify the comments and add the missing reset() calls. Unfortunately the tests still fail in the same way. On Fri, Oct 14, 2016 a

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Richard Smith via cfe-commits
On Fri, Oct 14, 2016 at 12:49 AM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Oct 14 02:49:15 2016 > New Revision: 284210 > > URL: http://llvm.org/viewvc/llvm-project?rev=284210&view=rev > Log: > XFAIL aligned allocation test failures with UBSAN

[libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 02:49:15 2016 New Revision: 284210 URL: http://llvm.org/viewvc/llvm-project?rev=284210&view=rev Log: XFAIL aligned allocation test failures with UBSAN Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_va