Re: [libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

2016-07-20 Thread Eric Fiselier via cfe-commits
I think it should be fixed in r276200. I'll watch the bots. On Wed, Jul 20, 2016 at 4:39 PM, Eric Fiselier wrote: > Hi Lang, > > Sorry about the breakage. I always forget __clang_major__ and > __clang_minor__ are useless when dealing with apple-clang. > Who can I complain to about that? > > I'll

Re: [libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

2016-07-20 Thread Eric Fiselier via cfe-commits
Hi Lang, Sorry about the breakage. I always forget __clang_major__ and __clang_minor__ are useless when dealing with apple-clang. Who can I complain to about that? I'll check in a fix shortly. /Eric On Wed, Jul 20, 2016 at 3:32 PM, Lang Hames wrote: > Hi Eric, > > I'm seeing failures on the b

Re: [libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

2016-07-20 Thread Lang Hames via cfe-commits
Hi Eric, I'm seeing failures on the builders that look like they're related to this - http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/359/ Could you look in to what's going on here? - Lang. On Tue, Jul 19, 2016 at 11:36 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.l

[libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

2016-07-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 20 01:36:11 2016 New Revision: 276092 URL: http://llvm.org/viewvc/llvm-project?rev=276092&view=rev Log: Unbreak is_constructible tests for Clang <= 3.7. There is a bug in Clang's __is_constructible builtin that causes it to return true for function types; ex [T = void