Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-08-08 Thread Bruno Cardoso Lopes via cfe-commits
Ping! On Thu, Aug 4, 2016 at 8:03 AM, Adrian Prantl wrote: > >> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes >> wrote: >> >> Hi Eric, >> >> After we upgraded our green dragon bots to El Captain (10.11), the >> test below started to fail on some of our machines: >> >> -- >> test/std/experime

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-08-04 Thread Adrian Prantl via cfe-commits
> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes > wrote: > > Hi Eric, > > After we upgraded our green dragon bots to El Captain (10.11), the > test below started to fail on some of our machines: > > -- > test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-08-03 Thread Bruno Cardoso Lopes via cfe-commits
Hi Eric, After we upgraded our green dragon bots to El Captain (10.11), the test below started to fail on some of our machines: -- test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp TEST_CASE(hard_link_count_for_directory) { uintmax_t DirExpect = 3;

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-06-21 Thread Eric Fiselier via cfe-commits
The issue should be fixed in r273323. Thanks for the report and for your patience. /Eric On Mon, Jun 20, 2016 at 11:27 PM, Eric Fiselier wrote: > Hi Artem, > > Sorry for the delay, I've been busy with school all day. > I'll check in a fix tomorrow morning. > > Sorry again, > > /Eric > > On Mon

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-06-20 Thread Eric Fiselier via cfe-commits
Hi Artem, Sorry for the delay, I've been busy with school all day. I'll check in a fix tomorrow morning. Sorry again, /Eric On Mon, Jun 20, 2016 at 2:31 PM, Eric Fiselier wrote: > Oh shoot, I definitely didn't take that into account. I'll put together a > fix. > > /Eric > > > > On Mon, Jun 20

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-06-20 Thread Eric Fiselier via cfe-commits
Oh shoot, I definitely didn't take that into account. I'll put together a fix. /Eric On Mon, Jun 20, 2016 at 2:27 PM, Artem Belevich wrote: > Eric, > > Some tests appear to fail if the path to the tests' current directory has > some symlinks in it. > In my case source and build tree are in di

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-06-20 Thread Artem Belevich via cfe-commits
Eric, Some tests appear to fail if the path to the tests' current directory has some symlinks in it. In my case source and build tree are in directory 'work' that's symlinked to from my home directory: /usr/local/home/tra/work -> /work/tra This causes multiple failures in libcxx tests. One exampl

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-06-18 Thread Eric Fiselier via cfe-commits
> I assume the correct way to fix this is to disable -Wcovered-switch-default while compiling libcxx/src/experimental/ filesystem/operations.cpp Agreed. Disabled in r273092. Thanks for your patience with this latest change, /Eric On Sat, Jun 18, 2016 at 12:54 PM, Adrian Prantl wrote: > Hello

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-06-18 Thread Adrian Prantl via cfe-commits
Hello Eric, this commit causes new warnings on our bots: clang/src/projects/libcxx/include/fstream:816:5: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default] default: The problem is with this defensive default statement in fstream: template 07