rjodinchr wrote:
@mgorny thank you for the report. It should be fixed with:
https://github.com/llvm/llvm-project/pull/99841
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
mgorny wrote:
This change seems to have caused test regression. This is Gentoo Linux amd64,
tried LLVM 72d8c2737bb557af9d0c735b9fa30b1b03485627 and 18.1.8.
To reproduce, I've done:
```
cmake -G Ninja "${llvm_project}"/libclc
-DLIBCLC_TARGETS_TO_BUILD="spirv-mesa3d-;spirv64-mesa3d-;r600--;amdg
rjodinchr wrote:
This PR should fix the build issue:
https://github.com/llvm/llvm-project/pull/99481
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
rjodinchr wrote:
I am able to reproduce it, working on it right now
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux`
running on `premerge-linux-1` while building `libclc` at step 6
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/153/builds/3385
Here is the relevant pi
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjodinchr wrote:
> @rjodinchr I was about to merge and noticed your email is hidden. I just
> wanted to check with you whether you want to make it public, as per the
> discussion
> https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223/67.
> AFAICT there's
frasercrmck wrote:
@rjodinchr I was about to merge and noticed your email is hidden. I just wanted
to check with you whether you want to make it public, as per the discussion
https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223/67.
AFAICT there's still no
frasercrmck wrote:
> Also, just leave that thought here: A next step might be to use `native`
> functions instead (when available). They should provide enough precision for
> half, but be more performance. Also as the accuracy is undefined for those
> functions, maybe it should be an opt-in op
rjodinchr wrote:
Also, just leave that thought here: A next step might be to use `native`
functions instead (when available). They should provide enough precision for
half, but be more performance. Also as the accuracy is undefined for those
functions, maybe it should be an opt-in option in th
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/98149
>From 449321d1d22c39201e132cbd8b5846cbe12dbe39 Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 9 Jul 2024 14:22:26 +0200
Subject: [PATCH] libclc: increase fp16 support
Increase fp16 support to allow cl
@@ -181,3 +181,15 @@ _CLC_OVERLOAD _CLC_DEF double atan(double x)
_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, atan, double);
#endif // cl_khr_fp64
+
+#ifdef cl_khr_fp16
rjodinchr wrote:
Alright, just found that it is due to includes order in `atan.cl
@@ -181,3 +181,15 @@ _CLC_OVERLOAD _CLC_DEF double atan(double x)
_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, atan, double);
#endif // cl_khr_fp64
+
+#ifdef cl_khr_fp16
rjodinchr wrote:
I agree, but I had some weird compilation errors. Does it work o
@@ -181,3 +181,15 @@ _CLC_OVERLOAD _CLC_DEF double atan(double x)
_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, atan, double);
#endif // cl_khr_fp64
+
+#ifdef cl_khr_fp16
frasercrmck wrote:
Can this be `_CLC_DEFINE_UNARY_BUILTIN_FP16(atan)`?
https://g
https://github.com/frasercrmck edited
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frasercrmck wrote:
> @frasercrmck Could you review it please?
Sure, will do, thanks for this. We've done something similar downstream so I
can hopefully verify against what we've done.
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits m
rjodinchr wrote:
@frasercrmck Could you review it please?
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alan-baker approved this pull request.
Looks reasonable to me.
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/98149
>From a387a97cc6ed89c65a9a80bc030e705ec864bf36 Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 9 Jul 2024 14:22:26 +0200
Subject: [PATCH] libclc: increase fp16 support
Increase fp16 support to allow cl
https://github.com/rjodinchr updated
https://github.com/llvm/llvm-project/pull/98149
>From c03c6e3a746fe6bfaf164151278db3cd32111f19 Mon Sep 17 00:00:00 2001
From: Romaric Jodin
Date: Tue, 9 Jul 2024 14:22:26 +0200
Subject: [PATCH] libclc: increase fp16 support
Increase fp16 support to allow cl
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 402eca265f7162e26b8b74d18297fd76c9f100de
4524f49360c28c6c024a9d13664773024ae053ad --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
402eca265f7162e26b8b74d18297fd76c9f100de...4524f49360c28c6c024a9d13664773024ae053ad
libcl
rjodinchr wrote:
@alan-baker @kpet , could you please review?
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjodinchr wrote:
Those implementations have been tested using 1 Intel and 1 AMD devices (with
clvk/clspv)
https://github.com/llvm/llvm-project/pull/98149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/rjodinchr created
https://github.com/llvm/llvm-project/pull/98149
Increase fp16 support to allow clspv to continue to be OpenCL compliant
following the update of the OpenCL-CTS adding more testing on math functions
and conversions with half.
Math functions are implemented b
26 matches
Mail list logo
