https://github.com/arsenm approved this pull request.
Title is misleading now, since this isn't moving the guards anymore
https://github.com/llvm/llvm-project/pull/122751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/frasercrmck updated
https://github.com/llvm/llvm-project/pull/122751
>From 4dd89f2be8e80797a8e921145339ac2716505830 Mon Sep 17 00:00:00 2001
From: Fraser Cormack
Date: Mon, 13 Jan 2025 17:29:06 +
Subject: [PATCH 1/2] [libclc] Move fp16 pragma guards out of header file
Ha
@@ -207,10 +207,6 @@
return BUILTIN(x);
\
}
-#ifdef cl_khr_fp16
-
-#pragma OPENCL EXTENSION cl_khr_fp16 : enable
-
#define _CLC_DEFINE_UNARY_BUILTIN_FP16(FUNCTION)
\
_CLC_DEF _CLC
@@ -207,10 +207,6 @@
return BUILTIN(x);
\
}
-#ifdef cl_khr_fp16
-
-#pragma OPENCL EXTENSION cl_khr_fp16 : enable
-
#define _CLC_DEFINE_UNARY_BUILTIN_FP16(FUNCTION)
\
_CLC_DEF _CLC
@@ -207,10 +207,6 @@
return BUILTIN(x);
\
}
-#ifdef cl_khr_fp16
-
-#pragma OPENCL EXTENSION cl_khr_fp16 : enable
-
#define _CLC_DEFINE_UNARY_BUILTIN_FP16(FUNCTION)
\
_CLC_DEF _CLC
https://github.com/frasercrmck created
https://github.com/llvm/llvm-project/pull/122751
Having the fp16 pragmas enabled in the header file is risky, as we have some
headers that also disable pragmas. We want to be as immune to changes in the
order of included header files as possible.
This pa
