[libclc] [libclc] Move fma to the CLC library (PR #126052)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/126052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move fma to the CLC library (PR #126052)

rjodinchr wrote: > > > FYI @rjodinchr this breaks downstream clspv testing. > > > ``` > > > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) > > > #2 > > > # | Unsupported llvm intrinsic > > > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > > > ``` >

[libclc] [libclc] Move fma to the CLC library (PR #126052)

frasercrmck wrote: > > FYI @rjodinchr this breaks downstream clspv testing. > > ``` > > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) #2 > > # | Unsupported llvm intrinsic > > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > > ``` > > > > > >

[libclc] [libclc] Move fma to the CLC library (PR #126052)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/126052 >From 18d67915671a081540abde18b1b6c009ac094a27 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Tue, 28 Jan 2025 12:19:23 + Subject: [PATCH 1/2] [libclc] Move fma to the CLC library This builtin is a

[libclc] [libclc] Move fma to the CLC library (PR #126052)

rjodinchr wrote: > FYI @rjodinchr this breaks downstream clspv testing. > > ``` > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) #2 > # | Unsupported llvm intrinsic > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > ``` > > I was wondering if clspv

[libclc] [libclc] Move fma to the CLC library (PR #126052)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/126052 >From b09ec4e569a2659eca66dc38e35a02a87134c209 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Tue, 28 Jan 2025 12:19:23 + Subject: [PATCH 1/2] [libclc] Move fma to the CLC library This builtin is a

[libclc] [libclc] Move fma to the CLC library (PR #126052)

frasercrmck wrote: FYI @rjodinchr this breaks downstream clspv testing. ``` # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) #2 # | Unsupported llvm intrinsic # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! ``` I was wondering if clspv should be transl

[libclc] [libclc] Move fma to the CLC library (PR #126052)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/126052 This builtin is a little more involved than others as targets deal with fma in various different ways. Fundamentally, the CLC __clc_fma builtin compiles to __builtin_elementwise_fma, which compiles to the @l