[libclc] [libclc] Fix building top-level 'libclc' target (PR #150972)

2025-07-29 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/150972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix building top-level 'libclc' target (PR #150972)

2025-07-29 Thread Wenju He via cfe-commits
https://github.com/wenju-he approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/150972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix building top-level 'libclc' target (PR #150972)

2025-07-29 Thread Fraser Cormack via cfe-commits
@@ -5,6 +5,9 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) endif() set(LLVM_SUBPROJECT_TITLE "libclc") +# Top level target used to build all Libclc libraries. +add_custom_target( libclc ALL ) frasercrmck wrote: Good idea - done. https://github.co

[libclc] [libclc] Fix building top-level 'libclc' target (PR #150972)

2025-07-29 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/150972 >From d08c5dea1b8ee797c27869e436b24b85a2d285bc Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Mon, 28 Jul 2025 15:57:11 +0100 Subject: [PATCH 1/2] [libclc] Fix building top-level 'libclc' target With l

[libclc] [libclc] Fix building top-level 'libclc' target (PR #150972)

2025-07-28 Thread Wenju He via cfe-commits
@@ -5,6 +5,9 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) endif() set(LLVM_SUBPROJECT_TITLE "libclc") +# Top level target used to build all Libclc libraries. +add_custom_target( libclc ALL ) wenju-he wrote: can we put this line near line 48~49, o

[libclc] [libclc] Fix building top-level 'libclc' target (PR #150972)

2025-07-28 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/150972 With libclc being a 'runtime', the top-level build assumes that there is a corresopnding 'libclc' target. We previously weren't providing this, leading to a build failure if the user tried to build it. Thi