llvmbot wrote:
/pull-request llvm/llvm-project#126201
https://github.com/llvm/llvm-project/pull/126071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/126071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
/cherry-pick 26ecddb05d13c101ccd840a6710eb5f8b82de841
https://github.com/llvm/llvm-project/pull/126071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic milestoned
https://github.com/llvm/llvm-project/pull/126071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/126071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
Good point, I've changed this to use HINTS instead of PATHS. I'm not really
sure which one is more "correct" in this context, but sticking closer to the
previous behavior seems like a good idea...
https://github.com/llvm/llvm-project/pull/126071
__
https://github.com/nikic updated
https://github.com/llvm/llvm-project/pull/126071
>From 2badb9749472014dc02610a3a511b548bfe8a2ae Mon Sep 17 00:00:00 2001
From: Nikita Popov
Date: Thu, 6 Feb 2025 14:56:25 +0100
Subject: [PATCH 1/2] [libclc] Allow default path when looking for llvm-spirv
This is
https://github.com/frasercrmck commented:
I get where this is coming from, thanks.
However, note that with this change, the priority is changed so that
`llvm-spirv` will be picked up from the PATH environment variable *before*
`LLVM_TOOLS_BINARY_DIR`.
See the documentation for
[find_program]
https://github.com/nikic created
https://github.com/llvm/llvm-project/pull/126071
This is an external tool, so I don't think there is an expectation that it has
to be in the LLVM tools bindir. It may also be in the default system bindir
(which is not necessarily the same).
>From 2badb97494720
