Re: [libc++] PR25118: move include_next after #pragma system_header

2015-10-08 Thread Eric Fiselier via cfe-commits
The patch LGTM. However I would rather see the pragma in wrap itself in the `#if !defined(_LIBPP_HAS_NO_SYSTEM_HEADER_PRAGMA)`. I agree that we probably shouldn't include "<__config>". However people are still free to add the definition to the command line (line libc++ does when building and test

[libc++] PR25118: move include_next after #pragma system_header

2015-10-08 Thread Richard Smith via cfe-commits
Hi, As noted in PR25118, people who include libc++'s headers via a -I path with -pedantic_errors will see errors due to the use of #include_next. This patch moves the #include_next after the #pragma system_header line to suppress the error. (For the __need_* case in , I'm not checking whether pra