Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

2019-01-30 Thread Mikael Holmén via cfe-commits
On 1/30/19 10:41 AM, Ilya Biryukov wrote: > Should be fixed by r352612, let me know if it pops up again. > This was a use after move, probably gcc and clang prefer different > evaluation order, hence the difference in behaviours. Awesome! Now it passes also when I compile with gcc. Thanks, Mik

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

2019-01-30 Thread Ilya Biryukov via cfe-commits
Should be fixed by r352612, let me know if it pops up again. This was a use after move, probably gcc and clang prefer different evaluation order, hence the difference in behaviours. On Wed, Jan 30, 2019 at 12:12 PM Ilya Biryukov wrote: > Hi Mikael, > > I suspect an undefined value creeps in for

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

2019-01-30 Thread Ilya Biryukov via cfe-commits
Hi Mikael, I suspect an undefined value creeps in for protocol capabilities, given that we have responses in different formats. I'll investigate, thanks for the report! On Wed, Jan 30, 2019 at 12:05 PM Mikael Holmén wrote: > Hi Ilya, > > I've no idea why, but when I compile this commit with gcc

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

2019-01-30 Thread Mikael Holmén via cfe-commits
Hi Ilya, I've no idea why, but when I compile this commit with gcc (7.4.0) the test fixits-command.test fails, and the output from clangd is rather different from when I compile it with clang (3.6.0). So I run build-all/bin/clangd -lit-test < /data/repo/master/llvm-master/tools/clang/tools/ex

[clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

2019-01-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jan 29 06:17:36 2019 New Revision: 352494 URL: http://llvm.org/viewvc/llvm-project?rev=352494&view=rev Log: [clangd] Interfaces for writing code tweaks Summary: The code tweaks are an implementation of mini-refactorings exposed via the LSP code actions. They run in two