Re: [clang-tools-extra] r342036 - Fix buildbots after r342027

2018-09-14 Thread Kirill Bobyrev via cfe-commits
Oh, I see. Thank you very much for fixing it! I had concerns about platform dependence, but I’ve seen seen some tests in libcxx which use `if […]` so I thought it should be alright (because there was no REQUIRES there). I can see now, that it is a Darwin test, my bad. Again, thank you very much

Re: [clang-tools-extra] r342036 - Fix buildbots after r342027

2018-09-14 Thread Reid Kleckner via cfe-commits
That construct does not work on Windows, where we don't use bash. We use the lit internal shell, which doesn't support 'if [ ...]'. I marked it REQUIRES: shell in r342282. On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: omtcyfz > Date:

[clang-tools-extra] r342036 - Fix buildbots after r342027

2018-09-12 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Wed Sep 12 02:27:55 2018 New Revision: 342036 URL: http://llvm.org/viewvc/llvm-project?rev=342036&view=rev Log: Fix buildbots after r342027 Modified: clang-tools-extra/trunk/test/clangd/index-tools.test Modified: clang-tools-extra/trunk/test/clangd/index-tools.test URL: