Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-17 Thread Tim Northover via cfe-commits
On 17 October 2016 at 08:36, Haojian Wu wrote: > Sorry for the trouble and delay (I missed this email previously). No worries. I thought that might be what had happened, the weekend deluge can hide anything. > Should be fixed in r284391. Thanks. Tim. ___

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-17 Thread Haojian Wu via cfe-commits
Should be fixed in r284391. On Mon, Oct 17, 2016 at 4:59 PM, Haojian Wu wrote: > Hello Tim, > > Sorry for the trouble and delay (I missed this email previously). > > I'm looking into it. Could you give me a link to the problematic buildbot? > > On Mon, Oct 17, 2016 at 3:44 PM, Tim Northover > w

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-17 Thread Haojian Wu via cfe-commits
Hello Tim, Sorry for the trouble and delay (I missed this email previously). I'm looking into it. Could you give me a link to the problematic buildbot? On Mon, Oct 17, 2016 at 3:44 PM, Tim Northover wrote: > On 14 October 2016 at 13:33, Tim Northover > wrote: > > On 14 October 2016 at 06:01,

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-17 Thread Tim Northover via cfe-commits
On 14 October 2016 at 13:33, Tim Northover wrote: > On 14 October 2016 at 06:01, Haojian Wu via cfe-commits > wrote: >> + std::string GuardName(FileName); >> + if (IsHeader) { >> +std::replace(GuardName.begin(), GuardName.end(), '/', '_'); >> +std::replace(GuardName.begin(), GuardName.e

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-14 Thread Tim Northover via cfe-commits
Hi Haojian, On 14 October 2016 at 06:01, Haojian Wu via cfe-commits wrote: > + std::string GuardName(FileName); > + if (IsHeader) { > +std::replace(GuardName.begin(), GuardName.end(), '/', '_'); > +std::replace(GuardName.begin(), GuardName.end(), '.', '_'); > +std::replace(GuardName

[clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 14 08:01:36 2016 New Revision: 284233 URL: http://llvm.org/viewvc/llvm-project?rev=284233&view=rev Log: [clang-move] Add header guard for the new header. Summary: The header guard generated by clang-move isn't always a perfect style, just avoid getting the header incl