Re: [clang-tools-extra] r273660 - Remove ignoringImplicit from clang-tidy.

2016-06-24 Thread Cong Liu via cfe-commits
It was the previous revision that broke tests, http://reviews.llvm.org/rL273659. It moved ignoringImplicit to ASTMatcher, caused some namespace conflict in clang-tidy/misc/DanglingHandleCheck.cpp. And r273660 solves that, tests are not broken after this revision. On Fri, Jun 24, 2016 at 12:32 PM R

Re: [clang-tools-extra] r273660 - Remove ignoringImplicit from clang-tidy.

2016-06-24 Thread Renato Golin via cfe-commits
On 24 June 2016 at 10:39, Cong Liu via cfe-commits wrote: > Author: congliu > Date: Fri Jun 24 04:39:28 2016 > New Revision: 273660 > > URL: http://llvm.org/viewvc/llvm-project?rev=273660&view=rev > Log: > Remove ignoringImplicit from clang-tidy. Hi Cong, Isn't this leaving untested code in tree

[clang-tools-extra] r273660 - Remove ignoringImplicit from clang-tidy.

2016-06-24 Thread Cong Liu via cfe-commits
Author: congliu Date: Fri Jun 24 04:39:28 2016 New Revision: 273660 URL: http://llvm.org/viewvc/llvm-project?rev=273660&view=rev Log: Remove ignoringImplicit from clang-tidy. Modified: clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp clang-tools-extra/trunk/clang-tidy/uti