MichelleCDjunaidi wrote:
PR opened.
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MichelleCDjunaidi wrote:
Will open the issue soon (since mobile Github is accessible), but the
additional new PR will be in a few days (no access to laptop currently)
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-co
AaronBallman wrote:
> Hmm, in that case, would it be better to note the Windows exception in the
> documentation and open up an issue tracker for the tab issue instead, since
> the bug and fix (due to it affecting all tab-related operations on Windows)
> is out of scope for this documentation
MichelleCDjunaidi wrote:
Hmm, in that case, would it be better to note the Windows exception in the
documentation and open up an issue tracker for the tab issue instead, since the
bug and fix (due to it affecting all tab-related operations on Windows) is out
of scope for this documentation PR?
AaronBallman wrote:
There is no workaround on Windows currently; the issue is that tab
autocompletion is handled via
https://github.com/llvm/llvm-project/blob/0797c184c636889f2897746dc71390ae28005c7c/llvm/lib/LineEditor/LineEditor.cpp#L212
and that's not available on Windows; we don't have any
MichelleCDjunaidi wrote:
I see; thanks for notifying me! Does anyone know of the workaround on Windows,
or should I try to find it after I have access to my laptop?
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-comm
AaronBallman wrote:
> If anyone reads this and tests it out, please tell the results. I'll open a
> new PR to add the Windows exception if it doesn't work. (Or if there's a
> better workflow that LLVM uses, do tell.)
Correct, it doesn't work out of the box on Windows.
https://github.com/llvm/
MichelleCDjunaidi wrote:
@LegalizeAdulthood Thanks for bringing this up because it slipped my mind to
test it on Windows! I honestly have only tested it on Linux, and I currently
don't have access to my laptop for the week.
If anyone reads this and tests it out, please tell the results. I'll o
LegalizeAdulthood wrote:
> Alternatively, pressing the tab key after a previous matcher's open
> parentheses would also
Did you try this on Windows? Because in my experience all these TAB-complete
actions depend on GNU readline which doesn't work on Windows.
https://github.com/llvm/llvm-proj
AaronBallman wrote:
This should now be resolved in 97122550961944f2376f0e84a73cdd5b9e042bc4
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
AaronBallman wrote:
> From another pull #106675, why is this failing the build-bot? Any ideas? Do I
> have to create a new PR just to fix this? @AaronBallman
>
> ```
> -- Build files have been written to:
> /home/runner/work/llvm-project/llvm-project/clang-tools-extra-build
> ninja: Entering d
MichelleCDjunaidi wrote:
>From another pull #106675, why is this failing the build-bot? Any ideas?
```
-- Build files have been written to:
/home/runner/work/llvm-project/llvm-project/clang-tools-extra-build
ninja: Entering directory `clang-tools-extra-build'
[1/2] Generating man Sphinx documen
github-actions[bot] wrote:
@MichelleCDjunaidi Congratulations on having your first Pull Request (PR)
merged into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem wit
AaronBallman wrote:
> Yeah, I don't have write permissions, so I need someone to land the changes
> on my behalf. Thank you so much! @AaronBallman
Thank you! We always appreciate improved documentation!
https://github.com/llvm/llvm-project/pull/106672
__
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MichelleCDjunaidi wrote:
Yeah, I don't have write permissions, so I need someone to land the changes on
my behalf.
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
AaronBallman wrote:
Do you need someone to land the changes on your behalf?
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti approved this pull request.
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -664,6 +679,17 @@ compiled against the version of clang-tidy that will be
loading the plugin.
The plugins can use threads, TLS, or any other facilities available to in-tree
code which is accessible from the external headers.
+Note that testing checks out of tree might invo
@@ -646,10 +658,13 @@ directory. The path to this directory is available in a
lit test with the varia
Out-of-tree check plugins
-
+
Developing an out-of-tree check as a plugin largely follows the steps
-outlined above. The plugin is a shared library
@@ -336,13 +337,24 @@ a starting point for your test cases. A rough outline of
the process looks like
The quickest way to prototype your matcher is to use :program:`clang-query` to
interactively build up your matcher. For complicated matchers, build up a
matching
expression
https://github.com/MichelleCDjunaidi updated
https://github.com/llvm/llvm-project/pull/106672
>From 3518ede871664d3d0f45a51b9e462b53ffa4a7d4 Mon Sep 17 00:00:00 2001
From: MichelleCDjunaidi <87893361+michellecdjuna...@users.noreply.github.com>
Date: Fri, 30 Aug 2024 14:40:39 +0800
Subject: [PATC
@@ -690,8 +716,8 @@ warnings and errors. The script provides multiple
configuration flags.
that the file names are matched against.
``run-clang-tidy.py clang-tidy/.*Check\.cpp`` will only analyze clang-tidy
checks. It may also be necessary to restrict the header files th
@@ -336,13 +337,24 @@ a starting point for your test cases. A rough outline of
the process looks like
The quickest way to prototype your matcher is to use :program:`clang-query` to
interactively build up your matcher. For complicated matchers, build up a
matching
expression
@@ -664,6 +679,17 @@ compiled against the version of clang-tidy that will be
loading the plugin.
The plugins can use threads, TLS, or any other facilities available to in-tree
code which is accessible from the external headers.
+Note that testing checks out of tree might invo
https://github.com/5chmidti commented:
Thanks for clearing things up in the docs
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -646,10 +658,13 @@ directory. The path to this directory is available in a
lit test with the varia
Out-of-tree check plugins
-
+
Developing an out-of-tree check as a plugin largely follows the steps
-outlined above. The plugin is a shared library
@@ -336,13 +337,24 @@ a starting point for your test cases. A rough outline of
the process looks like
The quickest way to prototype your matcher is to use :program:`clang-query` to
interactively build up your matcher. For complicated matchers, build up a
matching
expression
https://github.com/AaronBallman commented:
Thank you for working on this, the changes mostly LGTM aside from some minor
nits.
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/106672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clang-tidy
Author: None (MichelleCDjunaidi)
Changes
Update the documentation to direct new users to the Github instead of the
discontinued Phabricator archive. Also details more ways and information
regarding clan
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/MichelleCDjunaidi created
https://github.com/llvm/llvm-project/pull/106672
Update the documentation to direct new users to the Github instead of the
discontinued Phabricator archive. Also details more ways and information
regarding clang-query usage. Partially resolves/discl
35 matches
Mail list logo