bob80905 wrote:
Closing this PR since https://github.com/llvm/llvm-project/pull/98099 resolves
the issue and has already been merged.
https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/9] if debug exists, go up an extra dir
---
clang-tools-extra/
@@ -25,12 +25,14 @@ set(assets
)
set(asset_dir "${CMAKE_CURRENT_SOURCE_DIR}/../assets")
-set(resource_dir "${CMAKE_BINARY_DIR}/share/clang-doc")
set(out_files)
function(copy_files_to_dst src_dir dst_dir file)
set(src "${src_dir}/${file}")
set(dst "${dst_dir}/${file}"
https://github.com/bogner approved this pull request.
It's kind of unfortunate how this works dependency-wise - we end up creating
"Debug/share/clang-doc/${f}" even when we only build "Release" and vice-versa,
as the "copy-clang-doc-assets" explicitly depends on each version of this file.
Also
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25,17 +25,15 @@ set(assets
)
set(asset_dir "${CMAKE_CURRENT_SOURCE_DIR}/../assets")
-set(resource_dir "${CMAKE_BINARY_DIR}/share/clang-doc")
set(out_files)
function(copy_files_to_dst src_dir dst_dir file)
set(src "${src_dir}/${file}")
set(dst "${dst_dir}/${file}"
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/8] if debug exists, go up an extra dir
---
clang-tools-extra/
@@ -25,17 +25,15 @@ set(assets
)
set(asset_dir "${CMAKE_CURRENT_SOURCE_DIR}/../assets")
-set(resource_dir "${CMAKE_BINARY_DIR}/share/clang-doc")
set(out_files)
function(copy_files_to_dst src_dir dst_dir file)
set(src "${src_dir}/${file}")
set(dst "${dst_dir}/${file}"
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/damyanp edited
https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/7] if debug exists, go up an extra dir
---
clang-tools-extra/
@@ -44,7 +42,10 @@ foreach(f ${assets})
install(FILES ${asset_dir}/${f}
DESTINATION "${CMAKE_INSTALL_DATADIR}/clang-doc"
COMPONENT clang-doc)
- copy_files_to_dst(${asset_dir} ${resource_dir} ${f})
+ foreach(config ${CMAKE_CONFIGURATION_TYPES})
bob8
@@ -44,7 +42,10 @@ foreach(f ${assets})
install(FILES ${asset_dir}/${f}
DESTINATION "${CMAKE_INSTALL_DATADIR}/clang-doc"
COMPONENT clang-doc)
- copy_files_to_dst(${asset_dir} ${resource_dir} ${f})
+ foreach(config ${CMAKE_CONFIGURATION_TYPES})
damy
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/6] if debug exists, go up an extra dir
---
clang-tools-extra/
bogner wrote:
> Updated the description. In my tests, there are at least 5 copies of this
> file in the overall build output directory:
>
> ```
> //Debug/share/clang-doc
> //Release/share/clang-doc
> //MinSizeRel/share/clang-doc
> //RelWithDebInfo/share/clang-doc
> //share/clang-doc
> ```
>
>
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bob80905 wrote:
Updated the description.
In my tests, there are at least 5 copies of this file in the overall build
output directory:
```
//Debug/share/clang-doc
//Release/share/clang-doc
//MinSizeRel/share/clang-doc
//RelWithDebInfo/share/clang-doc
//share/clang-doc
```
Yes, one per configurati
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
damyanp wrote:
I don't think that the current description matches the change?
Does this mean that there'll likely be 3 copies of each file. One per
configuration, and another copy just in the binary directory?
https://github.com/llvm/llvm-project/pull/97505
___
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/5] if debug exists, go up an extra dir
---
clang-tools-extra/
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/4] if debug exists, go up an extra dir
---
clang-tools-extra/
@@ -167,7 +167,14 @@ llvm::Error getDefaultAssetFiles(const char *Argv0,
llvm::SmallString<128> AssetsPath;
AssetsPath = llvm::sys::path::parent_path(NativeClangDocPath);
- llvm::sys::path::append(AssetsPath, "..", "share", "clang-doc");
+ llvm::sys::path::append(AssetsP
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/97505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bogner requested changes to this pull request.
I don't think this is the right fix. The Release/Debug directories only exist
in the build tree, so this is incurring an unnecessary cost in an installed
clang-doc. Further, this won't work for configs like RelWithDebInfo.
Proba
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/3] if debug exists, go up an extra dir
---
clang-tools-extra/
bob80905 wrote:
An important assumption I'm making here is that the Debug directory cannot
exist without the Release directory. If this assumption doesn't hold, then this
fix will fail if only the release directory exists and debug is missing. I
believe by the nature of how the llvm project is
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/97505
>From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 2 Jul 2024 18:38:24 -0700
Subject: [PATCH 1/2] if debug exists, go up an extra dir
---
clang-tools-extra/
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Joshua Batista (bob80905)
Changes
In `clang-tools-extra\clang-doc\tool\ClangDocMain.cpp`, there is a function,
`getDefaultAssetFiles` that tries to find the location of
`\share\clang-doc\index.js`, but fails. This i
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/97505
In `clang-tools-extra\clang-doc\tool\ClangDocMain.cpp`, there is a function,
`getDefaultAssetFiles` that tries to find the location of
`\share\clang-doc\index.js`, but fails. This is because there are
alternat
30 matches
Mail list logo
