[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

2023-12-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > What about a slightly different take? What if in addition to adding > `clangdLanguages` (without HLSL) we also add `clangdExperimentalFeatures` and > add `HLSL` there. The problem I'm trying to solve here is to avoid someone > enabling HLSL on a language server that doe

[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

2023-12-19 Thread Chris B via cfe-commits
llvm-beanz wrote: > 1. Since the key we're adding to the server capabilities is a non-standard > extension, I'm a bit uneasy about giving it a general name like > `"languages"`. If the LSP were to add a key with that name but a different > format or interpretation, we could run into trouble. C

[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

2023-12-18 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: Thanks for the patch! I like the idea of having the server announce support for a list of languages, that seems nice and general and extensible. A couple of thoughts: 1. Since the key we're adding to the server capabilities is a non-standard exte

[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

2023-12-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Chris B (llvm-beanz) Changes This change adds a list of supported langauges as part of the server capabilities. This is related to a PR to add HLSL support to the clangd VSCode plugin (https://github.com/clangd/vscode-clangd/pull/392).

[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

2023-12-15 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/75633 This change adds a list of supported langauges as part of the server capabilities. This is related to a PR to add HLSL support to the clangd VSCode plugin (https://github.com/clangd/vscode-clangd/pull/392).