https://github.com/HighCommander4 requested changes to this pull request.
(marking 'request changes' per discussion in previous comments)
https://github.com/llvm/llvm-project/pull/75633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
HighCommander4 wrote:
> IIUC, we're trying to figure out if clangd should be used for documents for
> language `X`. We need to figure this out **before** clangd's proper
> initialization, so that we can decide which `documentSelector`s to provide.
Thanks, that's a good point that I overlooked!
kadircet wrote:
I am afraid exposing this in server capabilities might be too convoluted.
IIUC, we're trying to figure out if clangd should be used for documents for
language `X`. We need to figure this out **before** clangd's proper
initialization, so that we can decide which `documentSelecto
HighCommander4 wrote:
Using `"ServerCapabilities.experimental"` sounds reasonable to me.
https://github.com/llvm/llvm-project/pull/75633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
V-FEXrt wrote:
`ServerCapabilities` has this member:
```
/**
* Experimental server capabilities.
*/
experimental?: LSPAny;
```
Any reason we wouldn't just use that directly? maybe
```c++
llvm::json::Object ServerCaps{
...
{"experimental",
HighCommander4 wrote:
> What about a slightly different take? What if in addition to adding
> `clangdLanguages` (without HLSL) we also add `clangdExperimentalFeatures` and
> add `HLSL` there. The problem I'm trying to solve here is to avoid someone
> enabling HLSL on a language server that doe
llvm-beanz wrote:
> 1. Since the key we're adding to the server capabilities is a non-standard
> extension, I'm a bit uneasy about giving it a general name like
> `"languages"`. If the LSP were to add a key with that name but a different
> format or interpretation, we could run into trouble. C
https://github.com/HighCommander4 commented:
Thanks for the patch!
I like the idea of having the server announce support for a list of languages,
that seems nice and general and extensible.
A couple of thoughts:
1. Since the key we're adding to the server capabilities is a non-standard
exte
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Chris B (llvm-beanz)
Changes
This change adds a list of supported langauges as part of the server
capabilities. This is related to a PR to add HLSL support to the clangd VSCode
plugin (https://github.com/clangd/vscode-clangd/pull/392).
https://github.com/llvm-beanz created
https://github.com/llvm/llvm-project/pull/75633
This change adds a list of supported langauges as part of the server
capabilities. This is related to a PR to add HLSL support to the clangd VSCode
plugin (https://github.com/clangd/vscode-clangd/pull/392).
10 matches
Mail list logo
