https://github.com/PeterChou1 closed
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM, but test locally w/ LLVM_ENABLE_EXPENSIVE_CHECKS=On
https://llvm.org/docs/CMake.html. If that passes, then go ahead and land this,
since I think the nondeterminism in output order will be accounted for.
https://github.com/llvm/llvm-p
@@ -312,6 +322,20 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+// Sort by declaration locati
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -205,6 +205,22 @@ llvm::Error getHtmlAssetFiles(const char *Argv0,
return getDefaultAssetFiles(Argv0, CDCtx);
}
+/// Make the output of clang-doc deterministic by sorting the children of
+/// namespaces and records.
+void sortUsrToInfo(llvm::StringMap> &USRToInfo) {
+ fo
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/14] [clang-doc] uncomment unsupported
---
clang-tools-extra/
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/14] [clang-doc] uncomment unsupported
---
clang-tools-extra/
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
@@ -205,6 +205,22 @@ llvm::Error getHtmlAssetFiles(const char *Argv0,
return getDefaultAssetFiles(Argv0, CDCtx);
}
+/// Make the output of clang-doc deterministic by sorting the children of
+/// namespaces and records.
+void sortUsrToInfo(llvm::StringMap> &USRToInfo) {
+ fo
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/14] [clang-doc] uncomment unsupported
---
clang-tools-extra/
@@ -205,6 +205,22 @@ llvm::Error getHtmlAssetFiles(const char *Argv0,
return getDefaultAssetFiles(Argv0, CDCtx);
}
+/// Make the output of clang-doc deterministic by sorting the children of
+/// namespaces and records.
+void sortUsrToInfo(llvm::StringMap> &USRToInfo) {
+ fo
@@ -270,10 +273,12 @@ struct Info {
virtual ~Info() = default;
+ Info &operator=(Info &&Other) = default;
+
SymbolID USR =
SymbolID(); // Unique identifier for the decl described by this Info.
- const InfoType IT = InfoType::IT_default; // InfoType of this parti
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
@@ -205,6 +205,22 @@ llvm::Error getHtmlAssetFiles(const char *Argv0,
return getDefaultAssetFiles(Argv0, CDCtx);
}
+/// Make the output of clang-doc deterministic by sorting the children of
+/// namespaces and records.
+void sortUsrToInfo(llvm::StringMap> &USRToInfo) {
+ fo
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
@@ -270,10 +273,12 @@ struct Info {
virtual ~Info() = default;
+ Info &operator=(Info &&Other) = default;
+
SymbolID USR =
SymbolID(); // Unique identifier for the decl described by this Info.
- const InfoType IT = InfoType::IT_default; // InfoType of this parti
@@ -312,6 +317,16 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
+
+ bool operator<(const SymbolInfo &Other) const {
+if (DefLoc && Other.DefLoc) {
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/13] [clang-doc] uncomment unsupported
---
clang-tools-extra/
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/13] [clang-doc] uncomment unsupported
---
clang-tools-extra/
ilovepi wrote:
In the description, its probably better to use the `#` notation than
linkify `PR`. Most of us will only see the raw text in the commit message, and
while a full link is appreciated, it would be good to know the PR number at a
glance.
https://github.com/llvm/llvm-project/pull/10
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/12] [clang-doc] uncomment unsupported
---
clang-tools-extra/
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/12] [clang-doc] uncomment unsupported
---
clang-tools-extra/
@@ -104,6 +104,9 @@ struct Reference {
bool mergeable(const Reference &Other);
void merge(Reference &&I);
+ bool operator<(const Reference &Other) const {
ilovepi wrote:
My concern here is that we probably want clang-doc to output to be ordered
consiste
@@ -104,6 +104,9 @@ struct Reference {
bool mergeable(const Reference &Other);
void merge(Reference &&I);
+ bool operator<(const Reference &Other) const {
ilovepi wrote:
How stable are usrs? Perhaps we should be sorting on another property?
https://gith
@@ -384,5 +384,12 @@ ClangDocContext::ClangDocContext(tooling::ExecutionContext
*ECtx,
}
}
+void ScopeChildren::sort() {
+ std::sort(Namespaces.begin(), Namespaces.end());
ilovepi wrote:
Prefer llvm::sort.
https://llvm.org/docs/CodingStandards.html#bewar
https://github.com/PeterChou1 ready_for_review
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/11] [clang-doc] uncomment unsupported
---
clang-tools-extra/
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/11] [clang-doc] uncomment unsupported
---
clang-tools-extra/
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 01/10] [clang-doc] uncomment unsupported
---
clang-tools-extra/
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/9] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/8] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/7] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/6] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/5] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/7] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/6] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/5] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/4] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 03e1eb29e7169ddb0804b1d0b9d71d6d2aaf531d
114a5721e593a9b57ef31ed9856d0bce4a62da94 --e
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/101387
>From 3ec4d5b9e5bc24bfb466d65fd9c45c51fa6d3e94 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Wed, 31 Jul 2024 14:52:11 -0400
Subject: [PATCH 1/2] [clang-doc] uncomment unsupported
---
clang-tools-extra/te
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PeterChou1 wrote:
> This isn't fixing anything. Its re-enabling it. I'd also suggest adding
> people from that bug as reviewers to help you get this re-enabled.
This was just meant as an experiment to check what was failing in the CI
pipeline
https://github.com/llvm/llvm-project/pull/101387
_
ilovepi wrote:
This isn't fixing anything. Its re-enabling it. I'd also suggest adding people
from that bug as reviewers to help you get this re-enabled.
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.l
https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/101387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
56 matches
Mail list logo
