[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-10 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-10 Thread Zahira Ammarguellat via cfe-commits
@@ -501,6 +501,7 @@ class PreambleThread { } { +std::unique_lock Lock(Mutex); WithContext Guard(std::move(CurrentReq->Ctx)); zahiraam wrote: Thanks @tahonermann. I had forgotten about it. Closing it. https://github.com/llvm/llvm-

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-09 Thread Tom Honermann via cfe-commits
@@ -501,6 +501,7 @@ class PreambleThread { } { +std::unique_lock Lock(Mutex); WithContext Guard(std::move(CurrentReq->Ctx)); tahonermann wrote: Per private discussion, we determined that there isn't actually a bug here so long as

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-05 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann requested changes to this pull request. https://github.com/llvm/llvm-project/pull/118664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-05 Thread Tom Honermann via cfe-commits
@@ -501,6 +501,7 @@ class PreambleThread { } { +std::unique_lock Lock(Mutex); WithContext Guard(std::move(CurrentReq->Ctx)); tahonermann wrote: Unfortunately, I don't think this solves the issue by itself. Just prior to exiting t

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/118664 >From 35f795549d25ec1358b54ebd3f2176cf8e49aeff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 08:23:12 -0800 Subject: [PATCH 1/2] [NFC] Avoid data race condition. --- clang-tools-ext

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/118664 None >From 35f795549d25ec1358b54ebd3f2176cf8e49aeff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 08:23:12 -0800 Subject: [PATCH] [NFC] Avoid data race condition. --- clang-tools-e