github-actions[bot] wrote:
@e-kwsm Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
https://github.com/Dinistro closed
https://github.com/llvm/llvm-project/pull/94014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Dinistro wrote:
Then I'll merge it for you.
https://github.com/llvm/llvm-project/pull/94014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
e-kwsm wrote:
This PR is ready but I have no permission.
https://github.com/llvm/llvm-project/pull/94014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Dinistro wrote:
Do you have commit rights to land this or should I do it?
https://github.com/llvm/llvm-project/pull/94014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/94014
>From 3fcf81d949e461fb91b4e1713365da29ae1078cd Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(clang/**.py): fix comparison to None
from PEP8 (https://pe
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/94014
>From 70a3af851a0928bff0244a9d6fe4cd7fa0466a42 Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(clang/**.py): fix comparison to None
from PEP8 (https://pe
https://github.com/Dinistro approved this pull request.
https://github.com/llvm/llvm-project/pull/94014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Dinistro commented:
That seems a reasonable change. LGTM!
https://github.com/llvm/llvm-project/pull/94014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/94014
>From 406492bea31d26735d1da1087665e5cb46c8c1ea Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(clang/**.py): fix comparison to None
from PEP8 (https://pe
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/94014
>From cbc322d63ab460a1e13aa84b41c41c100fad13f9 Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(clang/**.py): fix comparison to None
from PEP8 (https://pe
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/94014
>From b7b811f25c9937e92a067f44c9e1a91d9d42fe47 Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(clang/**.py): fix comparison to None
from PEP8 (https://pe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eisuke Kawashima (e-kwsm)
Changes
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with is or is
not, never the equality operators.
---
Full diff: http
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/94014
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with is or is not,
> never the equality operators.
>From c37043d186214a1d112
15 matches
Mail list logo
