Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

2020-05-27 Thread Richard Smith via cfe-commits
On Tue, 26 May 2020 at 20:12, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On May 20, 2020, at 5:53 PM, Richard Smith wrote: > > On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi Richard, >> >> It looks like this p

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

2020-05-26 Thread Akira Hatanaka via cfe-commits
> On May 20, 2020, at 5:53 PM, Richard Smith wrote: > > On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Hi Richard, > > It looks like this patch will reject the following code, which used to > compile fine: > > $ cat test.cpp > #inc

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

2020-05-20 Thread Richard Smith via cfe-commits
On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > It looks like this patch will reject the following code, which used to > compile fine: > > $ cat test.cpp > #include > > typedef CF_ENUM(unsigned, TestEnum) { > A = 2, > B = 3,

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

2020-05-20 Thread Akira Hatanaka via cfe-commits
Hi Richard, It looks like this patch will reject the following code, which used to compile fine: $ cat test.cpp #include typedef CF_ENUM(unsigned, TestEnum) { A = 2, B = 3, }; $ clang++ -std=c++11 -c test.cpp test.cpp:3:9: error: non-defining declaration of enumeration with a fixed unde

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

2020-05-11 Thread Richard Smith via cfe-commits
On Mon, 11 May 2020 at 06:37, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sat, May 9, 2020 at 4:32 AM Richard Smith via cfe-commits > wrote: > > > > > > Author: Richard Smith > > Date: 2020-05-08T19:32:00-07:00 > > New Revision: c90e198107431f64b73686bdce31c293e3380ac7

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

2020-05-11 Thread Hans Wennborg via cfe-commits
On Sat, May 9, 2020 at 4:32 AM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-05-08T19:32:00-07:00 > New Revision: c90e198107431f64b73686bdce31c293e3380ac7 > > URL: > https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7 > DIFF: > htt

[clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

2020-05-08 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-05-08T19:32:00-07:00 New Revision: c90e198107431f64b73686bdce31c293e3380ac7 URL: https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7 DIFF: https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7.diff