jyknight wrote:
Some projects still seem to have a requirement for compatibility with GCC 4.8
-- which supports a lot of C++11 but didn't apply the change in CWG 1473, and
thus _require_ the space in `operator"" _udl`. That is somewhat unfortunate.
Two examples from the first page of github se
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Pre-commit CI failures appear to be unrelated.
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > LGTM, please keep an eye out for fallout in the wild though. It may be
> > interesting to see how many instances of `-Wno-deprecated-literal-operator`
> > exist now and do a search again before release to see how many new
> > instances show up.
>
> Thats a good idea! I
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/111027
>From 21dc8df292d85b7f48f75ea2a707be6c4971e2f9 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 3 Oct 2024 09:41:08 -0700
Subject: [PATCH 1/3] Turn Wdeprecated-literal-operator on by default
It would be
erichkeane wrote:
> LGTM, please keep an eye out for fallout in the wild though. It may be
> interesting to see how many instances of `-Wno-deprecated-literal-operator`
> exist now and do a search again before release to see how many new instances
> show up.
Thats a good idea! I did our init
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, please keep an eye out for fallout in the wild though. It may be
interesting to see how many instances of `-Wno-deprecated-literal-operator`
exist now and do a search again before release to see how many new instances
show up.
@@ -503,17 +503,16 @@ bool Sema::checkLiteralOperatorId(const CXXScopeSpec &SS,
const IdentifierInfo *II = Name.Identifier;
ReservedIdentifierStatus Status = II->isReserved(PP.getLangOpts());
SourceLocation Loc = Name.getEndLoc();
-if (!PP.getSourceManager().isI
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/111027
>From 21dc8df292d85b7f48f75ea2a707be6c4971e2f9 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 3 Oct 2024 09:41:08 -0700
Subject: [PATCH 1/3] Turn Wdeprecated-literal-operator on by default
It would be
https://github.com/Endilll commented:
I'm happy that we stop issuing diagnostics that contradict each other.
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -99,6 +99,20 @@ C++ Specific Potentially Breaking Changes
// Was error, now evaluates to false.
constexpr bool b = f() == g();
+- The warning ``-Wdeprecated-literal-operator`` is now on by default, as this
is
+ something that WG21 has shown interest in removing fr
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/111027
>From 21dc8df292d85b7f48f75ea2a707be6c4971e2f9 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 3 Oct 2024 09:41:08 -0700
Subject: [PATCH 1/2] Turn Wdeprecated-literal-operator on by default
It would be
@@ -203,6 +203,9 @@ namespace cwg1762 { // cwg1762: 14
float operator ""E(const char *);
// since-cxx11-error@-1 {{invalid suffix on literal; C++11 requires a space
between literal and identifier}}
// since-cxx11-warning@-2 {{user-defined literal suffixes not starting wi
@@ -203,6 +203,9 @@ namespace cwg1762 { // cwg1762: 14
float operator ""E(const char *);
// since-cxx11-error@-1 {{invalid suffix on literal; C++11 requires a space
between literal and identifier}}
// since-cxx11-warning@-2 {{user-defined literal suffixes not starting wi
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -203,6 +203,9 @@ namespace cwg1762 { // cwg1762: 14
float operator ""E(const char *);
// since-cxx11-error@-1 {{invalid suffix on literal; C++11 requires a space
between literal and identifier}}
// since-cxx11-warning@-2 {{user-defined literal suffixes not starting wi
@@ -203,6 +203,9 @@ namespace cwg1762 { // cwg1762: 14
float operator ""E(const char *);
// since-cxx11-error@-1 {{invalid suffix on literal; C++11 requires a space
between literal and identifier}}
// since-cxx11-warning@-2 {{user-defined literal suffixes not starting wi
https://github.com/Endilll commented:
The rest of changes to DR tests look good.
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/111027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -503,17 +503,16 @@ bool Sema::checkLiteralOperatorId(const CXXScopeSpec &SS,
const IdentifierInfo *II = Name.Identifier;
ReservedIdentifierStatus Status = II->isReserved(PP.getLangOpts());
SourceLocation Loc = Name.getEndLoc();
-if (!PP.getSourceManager().isI
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
It would be nice to see what our users think about this change, as this is
something that WG21/EWG quite wants to fix a handful of questionable issues
with UB. Depending on the outcome of this after being
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/111027
It would be nice to see what our users think about this change, as this is
something that WG21/EWG quite wants to fix a handful of questionable issues
with UB. Depending on the outcome of this after being co
24 matches
Mail list logo
