[clang] Treat escaped newlines as whitespace in Lexer::getRawToken. (PR #117548)

2024-11-26 Thread Samira Bazuzi via cfe-commits
https://github.com/bazuzi updated https://github.com/llvm/llvm-project/pull/117548 >From 9c8b31dc266b770927785834c841b8ae5a7ebb58 Mon Sep 17 00:00:00 2001 From: Samira Bazuzi Date: Fri, 22 Nov 2024 15:45:55 -0500 Subject: [PATCH 1/2] Treat escaped newlines as whitespace in Lexer::getRawToken.

[clang] Treat escaped newlines as whitespace in Lexer::getRawToken. (PR #117548)

2024-11-26 Thread Samira Bazuzi via cfe-commits
bazuzi wrote: > > If an escaped newline should not be considered whitespace, then instead of > > this change, getRawToken should be modified to return true when whitespace > > follows the escaped newline present at Loc > > That sounds like a more promising approach. Is that something you would

[clang] Treat escaped newlines as whitespace in Lexer::getRawToken. (PR #117548)

2024-11-26 Thread via cfe-commits
cor3ntin wrote: line splicing does not introduce spaces (https://compiler-explorer.com/z/ohaq6Wzv7). > If an escaped newline should not be considered whitespace, then instead of > this change, getRawToken should be modified to return true when whitespace > follows the escaped newline present

[clang] Treat escaped newlines as whitespace in Lexer::getRawToken. (PR #117548)

2024-11-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Samira Bazuzi (bazuzi) Changes The Lexer used in getRawToken is not told to keep whitespace, so when it skips over escaped newlines, it also ignores whitespace, regardless of getRawToken's IgnoreWhiteSpace parameter. My suspicion is that

[clang] Treat escaped newlines as whitespace in Lexer::getRawToken. (PR #117548)

2024-11-25 Thread Samira Bazuzi via cfe-commits
https://github.com/bazuzi created https://github.com/llvm/llvm-project/pull/117548 The Lexer used in getRawToken is not told to keep whitespace, so when it skips over escaped newlines, it also ignores whitespace, regardless of getRawToken's IgnoreWhiteSpace parameter. My suspicion is that user