[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread via cfe-commits
T-Gruber wrote: > > > Thanks for the ping. Looks really nice! FYI I just came across a case > > > last week w.r.t asm gotos. You can have a read > > > [here](https://sonarsource.atlassian.net/browse/CPP-5459) if you are > > > interested in the subject. > > > > > > Thank you! Looks interestin

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
steakhal wrote: > > Thanks for the ping. Looks really nice! FYI I just came across a case last > > week w.r.t asm gotos. You can have a read > > [here](https://sonarsource.atlassian.net/browse/CPP-5459) if you are > > interested in the subject. > > Thank you! Looks interesting. Does this mean

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread via cfe-commits
T-Gruber wrote: > Thanks for the ping. Looks really nice! FYI I just came across a case last > week w.r.t asm gotos. You can have a read > [here](https://sonarsource.atlassian.net/browse/CPP-5459) if you are > interested in the subject. Thank you! Looks interesting. Does this mean that the li

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 22ff7c5dc96828aba967fb3bcb3f929ea4509783 28b646792249bad0a01d9724cc538df5d41736da --

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,90 @@ +//===- ExprEngineVisitTest.cpp ---===// steakhal wrote: I think this should have the same length as the closing one. https://github.com/llvm/llvm-project/pull/95409 ___

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,90 @@ +//===- ExprEngineVisitTest.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WI

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
@@ -2057,11 +2057,16 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, llvm_unreachable("Support for MatrixSubscriptExpr is not implemented."); break; -case Stmt::GCCAsmStmtClass: +case Stmt::GCCAsmStmtClass: { Bldr.takeNodes(Pred); -

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal requested changes to this pull request. Thanks for the ping. Looks really nice! FYI I just came across a case last week w.r.t asm gotos. You can have a read [here](https://sonarsource.atlassian.net/browse/CPP-5459) if you are interested in the subject. https://githu

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-07-09 Thread via cfe-commits
T-Gruber wrote: Hi @steakhal , what is your opinion on this PR? Are there any open points from my side? https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-06-27 Thread via cfe-commits
https://github.com/T-Gruber edited https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-06-13 Thread via cfe-commits
T-Gruber wrote: > Could you please drop the format only changes so that I could focus on the > actual change set? I just reverted the format changes. Thanks for letting me know. https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-06-13 Thread Balazs Benics via cfe-commits
steakhal wrote: Could you please drop the format only changes so that I could focus on the actual change set? https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-06-13 Thread via cfe-commits
https://github.com/T-Gruber edited https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-06-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: None (T-Gruber) Changes Run PreStmt and PostStmt checker for GCCAsmStmt. Unittest to validate that corresponding callback functions are triggered. --- Patch is 89.28 KiB, truncated to 20.00 KiB

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-06-13 Thread via cfe-commits
https://github.com/T-Gruber edited https://github.com/llvm/llvm-project/pull/95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Run PreStmt/PostStmt checker for GCCAsmStmt (PR #95409)

2024-06-13 Thread via cfe-commits
https://github.com/T-Gruber created https://github.com/llvm/llvm-project/pull/95409 Run PreStmt and PostStmt checker for GCCAsmStmt. Unittest to validate that corresponding callback functions are triggered. >From 8fb59a5ab510cbe9d2f6322cb1c6252c8e0b7343 Mon Sep 17 00:00:00 2001 From: T-Gruber