[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-07 Thread Fangrui Song via cfe-commits
MaskRay wrote: > I think other folks than myself also got a similar problem, so it's not just > on my machine / setup. > > Should everybody set LLVM_DEFAULT_TARGET_TRIPLE with cmake instead of this > patch? Sorry, not very familiar with this... > > Would it be ok to apply this for now? The i

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-07 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: I think other folks than myself also got a similar problem, so it's not just on my machine / setup. Should everybody set LLVM_DEFAULT_TARGET_TRIPLE with cmake instead of this patch? Sorry, not very familiar with this... Would it be ok to apply this for now? https://github.c

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: > gcc -dumpmachine s390x-linux-gnu Then I am afraid your clang configuration is not correct. It previously detecting the GCC installation at `s390x-linux-gnu` is a mistake. You need to set LLVM_DEFAULT_TARGET_TRIPLE correctly. If for some reason you cannot change that, add `--g

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: gcc -dumpmachine s390x-linux-gnu https://github.com/llvm/llvm-project/pull/94729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: > `clang --version Target: s390x-ibm-linux` What's `gcc -dumpmachine`? Is that `s390x-linux-gnu`. If the normalized default target triple `s390x-ibm-linux`, it's not supposed to detect a GCC installation for `s390x-linux-gnu`. You probably need to check your LLVM_DEFAULT_TARGE

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: clang --version Target: s390x-ibm-linux https://github.com/llvm/llvm-project/pull/94729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: This is fine as a temporary workaround. What's `clang --version` on Ubuntu s390x? If it's390x-unknown-linux-gnu`, we have code to use `lib/s390x-linux-gnu`. CMake LLVM_DEFAULT_TARGET_TRIPLE can be used to set the default target triple. https://github.com/llvm/llvm-project/pull/9

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jonas Paulsson (JonPsson1) Changes This broke an Ubuntu build. This partially reverts 20d497c (SystemZ part only). --- Full diff: https://github.com/llvm/llvm-project/pull/94729.diff 1 Files Affected: - (modified) clang/lib/Driver/Too

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jonas Paulsson (JonPsson1) Changes This broke an Ubuntu build. This partially reverts 20d497c (SystemZ part only). --- Full diff: https://github.com/llvm/llvm-project/pull/94729.diff 1 Files Affected: - (modified) clang/lib/Dri

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-06 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 created https://github.com/llvm/llvm-project/pull/94729 This broke an Ubuntu build. This partially reverts 20d497c (SystemZ part only). >From 9340b545ec2381937919dfd925940a191244234b Mon Sep 17 00:00:00 2001 From: Jonas Paulsson Date: Fri, 7 Jun 2024 08:24:16 +02