[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc edited https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
chandlerc wrote: Build bot with the issue is now online and failing as expected, merging this revert to get in green (we hope). https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
chandlerc wrote: Sorry, let's keep discussion on the original PR -- I'll go post there. https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
chandlerc wrote: > I'm going to bring out Windows buildbot back online that was failing so that > when you do submit the revert, the bot should go back to green. I am looking > into this and will get back to you on the original bug when I find something. So, the builder came back up, and is no

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread via cfe-commits
dyung wrote: I'm going to bring out Windows buildbot back online that was failing so that when you do submit the revert, the bot should go back to green. I am looking into this and will get back to you on the original bug when I find something. https://github.com/llvm/llvm-project/pull/119638

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread via cfe-commits
https://github.com/dyung approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc updated https://github.com/llvm/llvm-project/pull/119638 >From 333befd054fb5da81f1349c8eba7255aa4e3ec12 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Wed, 11 Dec 2024 15:59:35 -0800 Subject: [PATCH 1/2] Revert "Switch builtin strings to use string tables (#

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc created https://github.com/llvm/llvm-project/pull/119638 Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build bots and at least s

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dd647e3e608ed0b2bac7c588d5859b80ef4a5976 333befd054fb5da81f1349c8eba7255aa4e3ec12 --e

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-m68k Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build bots

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-sparc Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build bots

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-hexagon Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build bo

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build bo

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build bots and at

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-systemz @llvm/pr-subscribers-backend-msp430 Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Chandler Carruth (chandlerc) Changes Reverts llvm/llvm-project#118734 There is currently a specific (unreleased?) version of MSVC and builder that are crashing / failing on this code. We don't know why as all the other build bot