AaronBallman wrote:
> I've seen this failure before, I don't think it's related to this PR.
I think it's related to https://github.com/llvm/llvm-project/pull/134196
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-comm
Endilll wrote:
I've seen this failure before, I don't think it's related to this PR.
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-4` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/19484
Here is th
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Jugst3r updated
https://github.com/llvm/llvm-project/pull/132776
Rate limit ยท GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
Jugst3r wrote:
Sure, I'll merge this! Thank you all for the reviews.
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
@Jugst3r are you still looking at this?
Otherwise, I would still suggest merging this.
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
Endilll wrote:
@Jugst3r Let us know if this is ready to be merged.
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
I talked to Aaron offline whether there's a better way to mark duplicates as
deprecated, but given the variety of C compilers that can consume this header,
we don't think there's a better way than a doxygen comment
https://github.com/llvm/
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
@Endilll if this fulfills your requested changes, can this be merged?
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/Jugst3r updated
https://github.com/llvm/llvm-project/pull/132776
>From bb4be5c1ab45dc927cfcada9b666d4ef0c1d863d Mon Sep 17 00:00:00 2001
From: Matthieu Eyraud
Date: Mon, 24 Mar 2025 14:38:50 +
Subject: [PATCH] libclang: deprecate duplicate API
Explicitly mark the clang_C
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1f967887018c63bddf5bf2860e0e6a3aa1e85840...ad58171d90be5e93c33c54f87f8c35096d13e680
clang
https://github.com/Jugst3r updated
https://github.com/llvm/llvm-project/pull/132776
>From a2b544902cb1a1436431ec8f5cfe54ad383d0f26 Mon Sep 17 00:00:00 2001
From: Matthieu Eyraud
Date: Mon, 24 Mar 2025 14:38:50 +
Subject: [PATCH] Remove duplicate API
And adapt the existing code to account f
Jugst3r wrote:
Sure, I did what @Endilll suggested. It is kind of unfortunate to have such
similar type names :/. I don't think I can use the [[attribute]] C++-style
syntax, maybe there is another syntax I am not aware of, but for the mean time
I put the deprecated inside the comments.
https:
https://github.com/Endilll requested changes to this pull request.
libclang's API is called stable for a reason.
It's too late to remove anything. The best we can do is to implement one
function in terms of another to avoid duplication on implementation side, and
put `[[deprecated("use the othe
@@ -423,12 +423,6 @@ LLVM_17 {
clang_getCursorUnaryOperatorKind;
};
-LLVM_19 {
- global:
-clang_Cursor_getBinaryOpcode;
-clang_Cursor_getBinaryOpcodeStr;
-};
-
Jugst3r wrote:
I think we have to remove it as this defines the list of symbols expose
@@ -423,12 +423,6 @@ LLVM_17 {
clang_getCursorUnaryOperatorKind;
};
-LLVM_19 {
- global:
-clang_Cursor_getBinaryOpcode;
-clang_Cursor_getBinaryOpcodeStr;
-};
-
DeinAlptraum wrote:
I don't think we should touch sections of this file from older ver
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/132776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum approved this pull request.
Oh wow, what an oversight. Thank you for this PR!
Looks good to me for the most part, it just needs a release note (especially
for the breaking change).
I'd also like @Endilll to sign off on this as well
https://github.com/llvm/llvm-pr
https://github.com/Jugst3r updated
https://github.com/llvm/llvm-project/pull/132776
>From f1edd98dfbe2a32e593e1a1a341838d3ccdbd38f Mon Sep 17 00:00:00 2001
From: Matthieu Eyraud
Date: Mon, 24 Mar 2025 14:38:50 +
Subject: [PATCH] Remove duplicate API
And adapt the existing code to account f
https://github.com/Jugst3r updated
https://github.com/llvm/llvm-project/pull/132776
>From a298a398accfe663cdbf34fd81e17188aadaee9b Mon Sep 17 00:00:00 2001
From: Matthieu Eyraud
Date: Mon, 24 Mar 2025 14:38:50 +
Subject: [PATCH] Remove duplicate API
And adapt the existing code to account f
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1f967887018c63bddf5bf2860e0e6a3aa1e85840
ad58171d90be5e93c33c54f87f8c35096d13e680 --e
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Jugst3r)
Changes
And adapt the existing code to account for the comments made when introducing
the duplicate API.
Note that this introduces a retro-incompatibility with LLVM 19.
cc @sebastianpoeplau
---
Full diff: https://github.
https://github.com/Jugst3r created
https://github.com/llvm/llvm-project/pull/132776
And adapt the existing code to account for the comments made when introducing
the duplicate API.
Note that this introduces a retro-incompatibility with LLVM 19.
cc @sebastianpoeplau
>From ad58171d90be5e93c33
25 matches
Mail list logo
