[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Takuto Ikuta via cfe-commits
atetubou wrote: Oh, I found https://code.visualstudio.com/docs/getstarted/settings#:~:text=modificationsIfAvailable. So let me use that instead. Thank you for your comments. https://github.com/llvm/llvm-project/pull/83974 ___ cfe-commits mailing lis

[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Takuto Ikuta via cfe-commits
https://github.com/atetubou closed https://github.com/llvm/llvm-project/pull/83974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Thank you for references both. > > Actually, I'd like to have PR like #83961. Is it acceptable to merge this > kind of PR in that case then? I don't feel the patches are related. I think you can only format the changed lines. https://github.com/llvm/llvm-project/pull/8397

[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Takuto Ikuta via cfe-commits
atetubou wrote: Thank you for references both. Actually, I'd like to have PR like https://github.com/llvm/llvm-project/pull/83961. Is it acceptable to merge this kind of PR in that case then? https://github.com/llvm/llvm-project/pull/83974 ___ cfe-co

[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Bulk formatting of Clang is still under discussion in https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614. At least I don't see a consensus called there one way or another. Our [developer policy](https://llvm.org/docs/DeveloperPolicy.html) states the following: >

[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Oh, I found it here: https://llvm.org/docs/CodingStandards.html#introduction > Our long term goal is for the entire codebase to follow the convention, but > we explicitly do not want patches that do large-scale reformatting of > existing code. https://github.com/llvm/llvm-pr

[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I remember we have policies that we don't like patches which purely formats codes. It makes backporting and cherry-picking harder. But I can't find the wording now. CC: @AaronBallman @Endilll https://github.com/llvm/llvm-project/pull/83974 __

[clang] [clang][NFC] Format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Takuto Ikuta via cfe-commits
https://github.com/atetubou edited https://github.com/llvm/llvm-project/pull/83974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] NFC: format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Takuto Ikuta (atetubou) Changes This is to avoid modifying unrelated code when auto format is on in our editor. --- Patch is 25.91 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/83974.diff 1

[clang] NFC: format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Takuto Ikuta via cfe-commits
https://github.com/atetubou ready_for_review https://github.com/llvm/llvm-project/pull/83974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] NFC: format clang/lib/Sema/Sema.cpp (PR #83974)

2024-03-05 Thread Takuto Ikuta via cfe-commits
https://github.com/atetubou created https://github.com/llvm/llvm-project/pull/83974 This is to avoid modifying unrelated code when auto format is on in our editor. >From 8d660f8a15b04285a4218a22944aef902d645b27 Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Tue, 5 Mar 2024 17:34:15 +0900 Su