https://github.com/statham-arm closed
https://github.com/llvm/llvm-project/pull/110804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
Thanks for making the change!
https://github.com/llvm/llvm-project/pull/110804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smithp35 approved this pull request.
Thanks for the updates. I don't have any more comments. I've approved the patch
on my side. Will be worth waiting for a bit to see if any other reviewers have
any feedback.
https://github.com/llvm/llvm-project/pull/110804
@@ -217,15 +215,15 @@ struct MultilibSetSerialization {
template <> struct llvm::yaml::MappingTraits {
static void mapping(llvm::yaml::IO &io, MultilibSerialization &V) {
io.mapOptional("Dir", V.Dir);
-io.mapOptional("FatalError", V.FatalError);
+io.mapOptional("E
https://github.com/statham-arm updated
https://github.com/llvm/llvm-project/pull/110804
>From 531253ab8c33cc69a927b28a1608675cd9ef709c Mon Sep 17 00:00:00 2001
From: Simon Tatham
Date: Mon, 30 Sep 2024 16:12:00 +0100
Subject: [PATCH 1/4] [clang][Driver] Rename "FatalError" key to "Error" in
mu
https://github.com/smithp35 edited
https://github.com/llvm/llvm-project/pull/110804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -217,15 +215,15 @@ struct MultilibSetSerialization {
template <> struct llvm::yaml::MappingTraits {
static void mapping(llvm::yaml::IO &io, MultilibSerialization &V) {
io.mapOptional("Dir", V.Dir);
-io.mapOptional("FatalError", V.FatalError);
+io.mapOptional("E
https://github.com/statham-arm updated
https://github.com/llvm/llvm-project/pull/110804
>From 531253ab8c33cc69a927b28a1608675cd9ef709c Mon Sep 17 00:00:00 2001
From: Simon Tatham
Date: Mon, 30 Sep 2024 16:12:00 +0100
Subject: [PATCH 1/3] [clang][Driver] Rename "FatalError" key to "Error" in
mu
@@ -124,12 +124,11 @@ bool MultilibSet::select(const Driver &D, const
Multilib::flags_list &Flags,
}
// If this multilib is actually a placeholder containing a fatal
-// error message written by the multilib.yaml author, display that
-// error message, and ret
https://github.com/smithp35 commented:
Change looks good to me. A few small comment nits.
https://github.com/llvm/llvm-project/pull/110804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/smithp35 edited
https://github.com/llvm/llvm-project/pull/110804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/statham-arm updated
https://github.com/llvm/llvm-project/pull/110804
>From 531253ab8c33cc69a927b28a1608675cd9ef709c Mon Sep 17 00:00:00 2001
From: Simon Tatham
Date: Mon, 30 Sep 2024 16:12:00 +0100
Subject: [PATCH 1/2] [clang][Driver] Rename "FatalError" key to "Error" in
mu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f9fbfc587d793b25e5f3ea0c8fa1db949085b158
765e431243b8ee6df9e118d7c1b21b270bf68c11 --e
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Simon Tatham (statham-arm)
Changes
This PR contains two separate patches updating the "custom error message"
feature in `multilib.yaml` (#105684):
* Change the YAML keyword `FatalError` to `Error`, as @petrhosek
requested after the previ
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Simon Tatham (statham-arm)
Changes
This PR contains two separate patches updating the "custom error message"
feature in `multilib.yaml` (#105684):
* Change the YAML keyword `FatalError` to `Error`, as @petrhosek
requested after th
https://github.com/statham-arm created
https://github.com/llvm/llvm-project/pull/110804
This PR contains two separate patches updating the "custom error message"
feature in `multilib.yaml` (#105684):
* Change the YAML keyword `FatalError` to `Error`, as @petrhosek requested
after the previous
16 matches
Mail list logo
