https://github.com/MaskRay commented:
We need a test to clang/test/Driver/ohos.c similar to linux-ld.c
`clang_rt.crtbegin.o`.
You can add UNSUPPORTED: system-windows to ohos.c so that we don't need
backslashes.
https://github.com/llvm/llvm-project/pull/118192
___
nico wrote:
Aha! Yes, that bot does do incremental builds. (As do many devs.)
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phuang wrote:
I still cannot repro the problem locally, but base on th log in
http://45.33.8.238/linux/155432/step_6.txt . Looks like clang tries to search
runtime library at
"/usr/local/google/home/thakis/src/llvm-project/out/gn/lib/clang/20/lib/linux/libclang_rt.builtins-x86_64.a"
(It is th
phuang wrote:
I found out how to run the test, but I cannot reproduce the problem with my
change. I run the test with below steps:
1: `cmake -S llvm -B build -G Ninja -DCMAKE_BUILD_TYPE=Release
-DLLVM_ENABLE_PROJECTS="clang;lld"`
2: `ninja -C build`
3: `./build/bin/llvm-lit ./clang/test/Drive
phuang wrote:
> are there any prerequisite changes elsewhere that I need to port to it?
HI @nico, how to repro the problem locally? Is there a doc for it? or could you
please share steps? thanks
https://github.com/llvm/llvm-project/pull/118192
___
cf
kpdev wrote:
@phuang @nico Reverted. I will reland it after investigating the issue with GN
build bot
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
nico wrote:
If all other bots are happy, then I'm doing something wrong probably. If you
don't mind reverting, it'd be nice since then I can catch other, actual
problems, with the bot, but it's not a requirement.
https://github.com/llvm/llvm-project/pull/118192
kpdev wrote:
@nico Should I revert this patch for now?
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phuang wrote:
I am out of town this week. I will take a look when I return.
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kpdev wrote:
Hm... No, it should work. @phuang May I kindly ask you to take a look at this
issue? http://45.33.8.238/linux/155432/step_6.txt
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
nico wrote:
This broke check-clang on my linux box:
http://45.33.8.238/linux/155432/step_6.txt
That bot uses the GN build – are there any prerequisite changes elsewhere that
I need to port to it?
https://github.com/llvm/llvm-project/pull/118192
___
kpdev wrote:
Agree. Tests would be useful here. Thanks for mentioning it
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
In general, functional changes need tests. When the initial
https://reviews.llvm.org/D145227 landed, I did not have a chance to look, and
the tests may have gap. When adding new functionality, ensure that the test
coverage gets improved.
https://github.com/llvm/llvm-project/pul
github-actions[bot] wrote:
@phuang Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
https://github.com/kpdev closed https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phuang wrote:
> LGTM
Could you please help merge the PR? I don't see how to do it from my side.
Thanks.
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
phuang wrote:
Thanks for reviewing it.
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kpdev wrote:
LGTM
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/phuang updated
https://github.com/llvm/llvm-project/pull/118192
>From 206f8f800df7e51648ec00b110f2437dca5a3ff6 Mon Sep 17 00:00:00 2001
From: Peng Huang
Date: Tue, 15 Oct 2024 13:39:03 -0400
Subject: [PATCH 1/2] Fix build error for OHOS
For ohos targets, libclang_rt.builtins
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6568ceb9fa1c49383b2fa102a04fd8fd3af01491
206f8f800df7e51648ec00b110f2437dca5a3ff6 --e
kpdev wrote:
@phuang Hi! Thank you for the patch. Will take a look in the nearest pair of
days
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
21 matches
Mail list logo
