tex3d wrote:
@farzonl
> Here are just a handful of tests that we might want to update, but there are
> others:
I'm updating these tests that were called out. What others do I need to look
for? How do I know if I've found all the tests I need to update?
https://github.com/llvm/llvm-project/
@@ -13,7 +13,7 @@ using size_t = unsigned long;
#endif // SPIR
} // namespace std
-float __builtin_atan2f(float, float);
+float __builtin_erff(float);
farzonl wrote:
Just want to put a note here we are doing this because atan2 would no longer
test the callin
https://github.com/farzonl approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/113636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
farzonl wrote:
So the minute this lands our change is going to be visible across all backends.
Should we add any constraint intrinsic tests to `PowerPC`, `RISCV`, `SystemZ`,
etc?
Here are just a handful of tests that we might want to update, but there are
others:
- llvm/test/CodeGen/PowerPC/
@@ -13,7 +13,7 @@ using size_t = unsigned long;
#endif // SPIR
} // namespace std
-float __builtin_atan2f(float, float);
+float __builtin_erff(float);
tex3d wrote:
Right, I hope I captured that in the PR description above. If that's not clear
enough let me
https://github.com/tex3d edited https://github.com/llvm/llvm-project/pull/113636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tex3d updated
https://github.com/llvm/llvm-project/pull/113636
>From a6776121bb118fe4083ccb94fa582cca1aef7f9b Mon Sep 17 00:00:00 2001
From: Tex Riddell
Date: Tue, 15 Oct 2024 16:18:44 -0700
Subject: [PATCH 1/3] Emit constrained atan2 intrinsic for clang builtin
This change
https://github.com/tex3d edited https://github.com/llvm/llvm-project/pull/113636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tex3d edited https://github.com/llvm/llvm-project/pull/113636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota approved this pull request.
LGTM! Please add a note to the PR description about why is are you changing
atan2 to erff in clang/test/CodeGenCXX/builtin-calling-conv.cpp.
https://github.com/llvm/llvm-project/pull/113636
___
cfe
https://github.com/tex3d updated
https://github.com/llvm/llvm-project/pull/113636
>From 7c7b72b48e07e0f34c2ee65e11e70db37f8c88b3 Mon Sep 17 00:00:00 2001
From: Tex Riddell
Date: Tue, 15 Oct 2024 16:18:44 -0700
Subject: [PATCH 1/3] Emit constrained atan2 intrinsic for clang builtin
This change
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c03d09ce3eed336fea4d9283232383f6d4d4057d
b5a4c777280873e9827bb812b95cad32fbf6b7f4 --e
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Tex Riddell (tex3d)
Changes
This change is part of this proposal:
https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294
- `Builtins.td` - Add f16 support for libm atan2 builtin
- `CGBuiltin.cpp` - Emit constraint atan2 intr
https://github.com/tex3d updated
https://github.com/llvm/llvm-project/pull/113636
>From 0c9dfb67a7371b9c4087d7b54e6f93e780038117 Mon Sep 17 00:00:00 2001
From: Tex Riddell
Date: Tue, 15 Oct 2024 16:18:44 -0700
Subject: [PATCH 1/3] Emit constrained atan2 intrinsic for clang builtin
This change
https://github.com/tex3d created
https://github.com/llvm/llvm-project/pull/113636
This change is part of this proposal:
https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294
- `Builtins.td` - Add f16 support for libm atan2 builtin
- `CGBuiltin.cpp` - Emit constraint atan2 intrinsic fo
15 matches
Mail list logo
