github-actions[bot] wrote:
@memory-thrasher Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
Thanks, looks good, I'll wait for premerge checks to come back green before I
merge it.
https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
memory-thrasher wrote:
I finally got the tests to behave.
https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/memory-thrasher updated
https://github.com/llvm/llvm-project/pull/97792
>From 5e5b80efa1e1903884db1f4ee8d92f79d139e7f9 Mon Sep 17 00:00:00 2001
From: Sidney Kelley
Date: Thu, 4 Jul 2024 23:03:16 -0700
Subject: [PATCH] Adds support to clang"s windows mangler to handle template
https://github.com/memory-thrasher updated
https://github.com/llvm/llvm-project/pull/97792
>From 81095a3fd1b5ce76a17922ad40a47f6a4a4308ab Mon Sep 17 00:00:00 2001
From: Sidney Kelley
Date: Thu, 4 Jul 2024 23:03:16 -0700
Subject: [PATCH] Adds support to clang"s windows mangler to handle template
https://github.com/memory-thrasher updated
https://github.com/llvm/llvm-project/pull/97792
>From f0b53c557bcadc8b0d323144fc19f4b0f6767d94 Mon Sep 17 00:00:00 2001
From: Sidney Kelley
Date: Thu, 4 Jul 2024 23:03:16 -0700
Subject: [PATCH] Adds support to clang"s windows mangler to handle template
@@ -1938,12 +1946,23 @@ void
MicrosoftCXXNameMangler::mangleTemplateArgValue(QualType T,
mangleNumber(V.getLValueOffset().getQuantity());
} else if (!V.hasLValuePath()) {
// FIXME: This can only happen as an extension. Invent a mangling.
-break;
+
https://github.com/memory-thrasher updated
https://github.com/llvm/llvm-project/pull/97792
>From b3de931c063ed895b3fd040a6ef53f8422fc7741 Mon Sep 17 00:00:00 2001
From: Sidney Kelley
Date: Thu, 4 Jul 2024 23:03:16 -0700
Subject: [PATCH] Adds support to clang"s windows mangler to handle template
@@ -1938,12 +1946,23 @@ void
MicrosoftCXXNameMangler::mangleTemplateArgValue(QualType T,
mangleNumber(V.getLValueOffset().getQuantity());
} else if (!V.hasLValuePath()) {
// FIXME: This can only happen as an extension. Invent a mangling.
-break;
+
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk commented:
Sorry, I made this comment some time ago, but it looks like I never published it
https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
memory-thrasher wrote:
Alright. Pinging the other reviewers.
@rnk @tahonermann @MaxEW707 @zmodem
https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/memory-thrasher updated
https://github.com/llvm/llvm-project/pull/97792
>From d7223618f85cb14009c1b224b3b705cc78c54974 Mon Sep 17 00:00:00 2001
From: Sidney Kelley
Date: Thu, 4 Jul 2024 23:03:16 -0700
Subject: [PATCH] Adds support to clang"s windows mangler to handle template
bolshakov-a wrote:
LGTM, but I don't have the commit access, hence cannot merge your PR. Someone
closely related to the community should take a look.
https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
memory-thrasher wrote:
ya it's something with my local build env. same test is now failing when built
from the commit before mine. Looks like they passed on the build server though
so this should be ready. I fixed the things you mentioned @bolshakov-a . Let me
know if you have a different phra
memory-thrasher wrote:
an unrelated test (Modules/prune.m) is now failing on my end. I'm doing a clean
build because I suspect there's something stale in a cache somewhere.
https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
c
https://github.com/memory-thrasher updated
https://github.com/llvm/llvm-project/pull/97792
>From d47a70e4715a3f6f4740570877799d3bfbb8a713 Mon Sep 17 00:00:00 2001
From: Sidney Kelley
Date: Thu, 4 Jul 2024 23:03:16 -0700
Subject: [PATCH] Adds support to clang"s windows mangler to handle template
@@ -1938,12 +1946,23 @@ void
MicrosoftCXXNameMangler::mangleTemplateArgValue(QualType T,
mangleNumber(V.getLValueOffset().getQuantity());
} else if (!V.hasLValuePath()) {
// FIXME: This can only happen as an extension. Invent a mangling.
-break;
+
bolshakov-a wrote:
I'd prefer something simpler like:
```cpp
struct A { int* pi; };
template void TplFn();
int i;
void Fn() {
TplFn();
}
```
with checking of the full mangled name.
https://github.com/llvm/llvm-project/pull/97792
_
@@ -1938,12 +1946,23 @@ void
MicrosoftCXXNameMangler::mangleTemplateArgValue(QualType T,
mangleNumber(V.getLValueOffset().getQuantity());
} else if (!V.hasLValuePath()) {
// FIXME: This can only happen as an extension. Invent a mangling.
-break;
+
https://github.com/memory-thrasher edited
https://github.com/llvm/llvm-project/pull/97792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
22 matches
Mail list logo
