https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/78476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, that's a nice, easy change!
https://github.com/llvm/llvm-project/pull/78476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/AaronBallman deleted
https://github.com/llvm/llvm-project/pull/78476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7068,8 +7068,7 @@ static void checkAttributesAfterMerging(Sema &S,
NamedDecl &ND) {
if (WeakRefAttr *Attr = ND.getAttr()) {
if (ND.isExternallyVisible()) {
S.Diag(Attr->getLocation(), diag::err_attribute_weakref_not_static);
- ND.dropAttr();
- ND.drop
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/78476
>From 6790e56b001a29e8bba012514eb3b12cd486d505 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Wed, 17 Jan 2024 09:03:14 -0800
Subject: [PATCH 1/2] Add Variadic 'dropAttrs'
As suggested in https://github.com/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2cd013a7869a341a6536324c34f0c4e68bf01a38
6790e56b001a29e8bba012514eb3b12cd486d505 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
As suggested in https://github.com/llvm/llvm-project/pull/78200
This adds a variadic 'dropAttrs', which drops all attributes of any of the
types specified.
---
Full diff: https://github.com/llvm/llvm-proj
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/78476
As suggested in https://github.com/llvm/llvm-project/pull/78200
This adds a variadic 'dropAttrs', which drops all attributes of any of the
types specified.
>From 6790e56b001a29e8bba012514eb3b12cd486d505 Mon