Re: [clang] 8569465 - Add a Clang NATVIS visualizer for StringLiteral

2023-11-13 Thread David Blaikie via cfe-commits
On Mon, Nov 13, 2023 at 4:28 AM Aaron Ballman wrote: > On Sun, Nov 12, 2023 at 11:42 PM David Blaikie wrote: > > > > Any chance this could/should reference the length by name, rather than > by casts and pointer math? (so it's resilient to at least some changes to > StringLiteral/StringRef?) Or i

Re: [clang] 8569465 - Add a Clang NATVIS visualizer for StringLiteral

2023-11-13 Thread Aaron Ballman via cfe-commits
On Sun, Nov 12, 2023 at 11:42 PM David Blaikie wrote: > > Any chance this could/should reference the length by name, rather than by > casts and pointer math? (so it's resilient to at least some changes to > StringLiteral/StringRef?) Or is this the preferred way to write Natvis > visualizers, so

Re: [clang] 8569465 - Add a Clang NATVIS visualizer for StringLiteral

2023-11-12 Thread David Blaikie via cfe-commits
Any chance this could/should reference the length by name, rather than by casts and pointer math? (so it's resilient to at least some changes to StringLiteral/StringRef?) Or is this the preferred way to write Natvis visualizers, so they're resilient to missing debug info or something? On Sun, Nov

[clang] 8569465 - Add a Clang NATVIS visualizer for StringLiteral

2023-11-12 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-11-12T09:22:15-05:00 New Revision: 8569465adf5e6c792e88be56b0e6b24f1c74e633 URL: https://github.com/llvm/llvm-project/commit/8569465adf5e6c792e88be56b0e6b24f1c74e633 DIFF: https://github.com/llvm/llvm-project/commit/8569465adf5e6c792e88be56b0e6b24f1c74e633.diff