Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-03-02 Thread Sanjay Patel via cfe-commits
https://reviews.llvm.org/rG8cdcbcaa02e7 https://reviews.llvm.org/rG1e308452bf68 On Thu, Feb 27, 2020 at 6:29 PM Eric Christopher wrote: > Sure. That sounds great. Thanks! > > On Wed, Feb 26, 2020 at 10:45 AM Sanjay Patel > wrote: > >> To be clear - the test is checking IR instructions, but it's

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-27 Thread Eric Christopher via cfe-commits
Sure. That sounds great. Thanks! On Wed, Feb 26, 2020 at 10:45 AM Sanjay Patel wrote: > To be clear - the test is checking IR instructions, but it's checking -O1 > IR for various targets. > So there must be different expectations per target... > But I just tried a test of turning everything down

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-26 Thread Sanjay Patel via cfe-commits
To be clear - the test is checking IR instructions, but it's checking -O1 IR for various targets. So there must be different expectations per target... But I just tried a test of turning everything down to -O0, and it all passed except for the "fast-math" run for AArch64. I can tweak that to not be

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-26 Thread Eric Christopher via cfe-commits
I mean anything that's testing assembly output out of clang is less than ideal. There are some circumstances, but this doesn't seem like one of them. On Wed, Feb 26, 2020, 9:10 AM Sanjay Patel wrote: > The test file dates back to: > https://reviews.llvm.org/D5698 > ...and I'm not familiar with _

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-26 Thread Sanjay Patel via cfe-commits
The test file dates back to: https://reviews.llvm.org/D5698 ...and I'm not familiar with _Complex enough to say how to fix this properly (seems like the check lines are already limited such that -O0 rather than -O1 would work?). But this file keeps wiggling unexpectedly, it's going to move again w

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-25 Thread Eric Christopher via cfe-commits
Is there any way to pull this test out of clang and as an opt test? What's it trying to test? -eric On Tue, Feb 25, 2020 at 6:15 AM Sanjay Patel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sanjay Patel > Date: 2020-02-25T09:13:49-05:00 > New Revision: 83f4372f3a708ceaa800fef

[clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-25 Thread Sanjay Patel via cfe-commits
Author: Sanjay Patel Date: 2020-02-25T09:13:49-05:00 New Revision: 83f4372f3a708ceaa800feff8b1bd92ae2c3be5f URL: https://github.com/llvm/llvm-project/commit/83f4372f3a708ceaa800feff8b1bd92ae2c3be5f DIFF: https://github.com/llvm/llvm-project/commit/83f4372f3a708ceaa800feff8b1bd92ae2c3be5f.diff