Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

2021-06-28 Thread David Blaikie via cfe-commits
(ping on this) On Mon, May 10, 2021 at 8:37 AM David Blaikie wrote: > Christopher - had a chance to look into this any further? > > Roman - I'm OK either way on that. I don't think it's the most costly > false positive - not too much code is probably freeing via a reference > (rather than a poin

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

2021-05-10 Thread David Blaikie via cfe-commits
Christopher - had a chance to look into this any further? Roman - I'm OK either way on that. I don't think it's the most costly false positive - not too much code is probably freeing via a reference (rather than a pointer) to allocated memory. On Fri, Apr 30, 2021 at 10:08 AM Roman Lebedev wrot

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

2021-04-30 Thread Roman Lebedev via cfe-commits
Should the diagnostic be backed out until then? Roman On Fri, Apr 30, 2021 at 7:52 PM Christopher Di Bella via cfe-commits wrote: > > Sorry, not yet. I'll talk with my TL to see if I can get some time allotted > for this in the next few weeks. > > On Thu, 29 Apr 2021 at 16:13, David Blaikie wr

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

2021-04-30 Thread Christopher Di Bella via cfe-commits
Sorry, not yet. I'll talk with my TL to see if I can get some time allotted for this in the next few weeks. On Thu, 29 Apr 2021 at 16:13, David Blaikie wrote: > Ping on this - have you had a chance to look at this false positive? > > On Sat, Apr 3, 2021 at 4:29 PM David Blaikie wrote: > > > > L

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

2021-04-29 Thread David Blaikie via cfe-commits
Ping on this - have you had a chance to look at this false positive? On Sat, Apr 3, 2021 at 4:29 PM David Blaikie wrote: > > Looks like this has a false positive (that's firing on some mlir code, > committed a workaround in 499571ea835daf786626a0db1e12f890b6cd8f8d ) > like this: > > $ cat test.c

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

2021-04-03 Thread David Blaikie via cfe-commits
Looks like this has a false positive (that's firing on some mlir code, committed a workaround in 499571ea835daf786626a0db1e12f890b6cd8f8d ) like this: $ cat test.cpp #include void f1(int & x) { free(&x); } int main() { f1(*(int*)malloc(sizeof(int))); } Could you fix that? (& then revert the wor

[clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

2021-01-15 Thread Christopher Di Bella via cfe-commits
Author: Christopher Di Bella Date: 2021-01-15T21:38:47Z New Revision: 4a47da2cf440c2f2006d9b04acfef4292de1e263 URL: https://github.com/llvm/llvm-project/commit/4a47da2cf440c2f2006d9b04acfef4292de1e263 DIFF: https://github.com/llvm/llvm-project/commit/4a47da2cf440c2f2006d9b04acfef4292de1e263.dif