Re: [clang] 26dbb93 - [Driver] Fix -fpascal-strings on Darwin

2022-04-14 Thread Fangrui Song via cfe-commits
This fixed failure of clang_f_opts.c after bfafa105aab05e2c243e74114739b7d37f8ab0be when the LLVM_DEFAULT_TARGET_TRIPLE looks like arm64-apple-darwin. Sorry that I did not provide enough information in the message. I think the few lines in Darwin.cpp should just be removed since -mpascal-strings i

Re: [clang] 26dbb93 - [Driver] Fix -fpascal-strings on Darwin

2022-04-14 Thread Aaron Ballman via cfe-commits
Should there be some test coverage for this change (or was this fixing an already failing test)? ~Aaron On Thu, Apr 14, 2022 at 2:01 AM Fangrui Song via cfe-commits wrote: > > > Author: Fangrui Song > Date: 2022-04-13T23:00:57-07:00 > New Revision: 26dbb93704bf39a198909d04ad8c49b4bde46cce > > UR

[clang] 26dbb93 - [Driver] Fix -fpascal-strings on Darwin

2022-04-13 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-04-13T23:00:57-07:00 New Revision: 26dbb93704bf39a198909d04ad8c49b4bde46cce URL: https://github.com/llvm/llvm-project/commit/26dbb93704bf39a198909d04ad8c49b4bde46cce DIFF: https://github.com/llvm/llvm-project/commit/26dbb93704bf39a198909d04ad8c49b4bde46cce.diff