Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

2020-01-15 Thread Artem Belevich via cfe-commits
On Wed, Jan 15, 2020 at 3:09 PM Alexey Bataev wrote: > And I disabled it only for device side, which is NVPTX, no? Can host side > target class report that the target is NVPTX? If you look at the patch, it > disable RTTI only if current triple is NVPTX. Can it be true for the host? > You are corr

Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

2020-01-15 Thread Artem Belevich via cfe-commits
On Wed, Jan 15, 2020 at 2:52 PM Alexey Bataev wrote: > 1. The problem is that it does not produce errors, > ATM, it does produce errors when it's disabled. > it leads to the emission of some declaration that cannot be resolved by > the linker. This what I was trying to avoid. > I'm OK with disab

Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

2020-01-15 Thread Artem Belevich via cfe-commits
Thank you. In general, RTTI should probably be treated similar to how we deal with inline assembly and ignore errors if they are in the code that we're not going to codegen during this side of compilation. E.g. during host-side compilation we don't complain about GPU-side registers in inline assem

Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

2020-01-15 Thread Artem Belevich via cfe-commits
Alexey, This breaks compilation of our cuda code which happens to transitively include protobuf headers. Can you, please, revert it for now until we figure out how RTTI should be handled? --Artem On Tue, Jan 14, 2020 at 3:15 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote:

[clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

2020-01-14 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-01-14T18:12:06-05:00 New Revision: 23058f9dd4d7e18239fd63b6da52549514b45fda URL: https://github.com/llvm/llvm-project/commit/23058f9dd4d7e18239fd63b6da52549514b45fda DIFF: https://github.com/llvm/llvm-project/commit/23058f9dd4d7e18239fd63b6da52549514b45fda.diff