Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

2020-04-23 Thread Mikael Holmén via cfe-commits
On Thu, 2020-04-23 at 17:46 +0300, Kadir Çetinkaya wrote: > Thanks Mikael, sent out an ugly fix > at 89cb5d558895706e053bc3af972aa5b15aa82863 to get sanitizer build > bots running. > Nice, thanks! Now our buildbots went silent again. /Mikael > Will change the testing scheme for a proper fix. >

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

2020-04-23 Thread Kadir Çetinkaya via cfe-commits
Thanks Mikael, sent out an ugly fix at 89cb5d558895706e053bc3af972aa5b15aa82863 to get sanitizer build bots running. Will change the testing scheme for a proper fix. On Thu, Apr 23, 2020 at 4:53 PM Mikael Holmén wrote: > Hi Kadir, > > I start seeing some sanitizer complaints with this commit fo

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

2020-04-23 Thread Mikael Holmén via cfe-commits
Hi Kadir, I start seeing some sanitizer complaints with this commit for the following two testcases: ./ClangdTests/PreamblePatchTest.ContainsNewIncludes ./ClangdTests/PreamblePatchTest.IncludeParsing The complaints look like this: =

[clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

2020-04-21 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-04-21T10:27:26+02:00 New Revision: 2214b9076f1d3a4784820c4479e2417685e5c980 URL: https://github.com/llvm/llvm-project/commit/2214b9076f1d3a4784820c4479e2417685e5c980 DIFF: https://github.com/llvm/llvm-project/commit/2214b9076f1d3a4784820c4479e2417685e5c980.dif