keith wrote:
the latest commit seems to have fixed it!
https://github.com/llvm/llvm-project/pull/109909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
keith wrote:
should I cherry pick this for future releases?
https://github.com/llvm/llvm-project/pull/109909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running
on `hip-vega20-0` while building `clang` at step 3 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/123/builds/6757
Here is the relevant piece of the build log for
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/109909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
keith wrote:
https://github.com/llvm/llvm-project/pull/110701
https://github.com/llvm/llvm-project/pull/109909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
@keith Yes, this change needs to be in the release branch or it won't take
effect.
https://github.com/llvm/llvm-project/pull/109909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
@@ -109,3 +109,6 @@ set_final_stage_var(LLVM_ENABLE_PROJECTS
"${LLVM_RELEASE_ENABLE_PROJECTS}" STRIN
set_final_stage_var(CPACK_GENERATOR "TXZ" STRING)
set_final_stage_var(CPACK_ARCHIVE_THREADS "0" STRING)
+if(${CMAKE_HOST_SYSTEM_NAME} MATCHES "Darwin")
+ set_final_stage_var(
keith wrote:
It looks like at least 1 issue was that CMAKE_SYSTEM_NAME isn't set at the time
this configuration is loaded, I swapped it to use the host system name, which
is imperfect, but probably fine. Lets see if that works
https://github.com/llvm/llvm-project/pull/109909
__
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/109909
>From 8c6c06d0df5a17fd2ff4915c3de63695c18cd8dc Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Wed, 25 Sep 2024 05:38:04 +
Subject: [PATCH 1/5] workflows/release-binaries: Use static ZSTD on macOS
On macOS
tstellar wrote:
If you add these 3 options to the cmake invocation in release-binaries.yml, it
should give us more verbose output and make the problem easier to debug:
```
-DCMAKE_VERBOSE_MAKEFILE=ON \
-DBOOTSTRAP_CMAKE_VERBOSE_MAKEFILE=ON \
-DBOOTSTRAP_BOOTSTRAP_CMAKE_V
keith wrote:
ah thanks, looks like this didn't work then
https://github.com/llvm/llvm-project/pull/109909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
You want to be downloading and testing this artifact:
https://github.com/llvm/llvm-project/pull/109909
___
cfe-commits mailing list
cfe-commits@
keith wrote:
The build got further this time, but the binaries uploaded from this step:
https://github.com/user-attachments/assets/e27c3ab4-4f1f-44a1-a118-62d437084c65";>
still have the issue. I expected a new binary here, the same 2 clangs existed,
am I looking in the right place?
https://gi
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/109909
>From 4676d022d971ef1623b83a2731ce94572905d6ad Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Wed, 25 Sep 2024 05:38:04 +
Subject: [PATCH 1/4] workflows/release-binaries: Use static ZSTD on macOS
On macOS
keith wrote:
I downloaded the binaries from this stage again:
https://github.com/user-attachments/assets/bb37ccaa-5f5f-4c99-8491-0ec570cb0a69";>
and it looks like this change didn't apply to either of these binaries
`build/bin/clang build/tools/clang/stage2-bins/bin/clang`. If it had passed
w
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/109909
>From 8c6c06d0df5a17fd2ff4915c3de63695c18cd8dc Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Wed, 25 Sep 2024 05:38:04 +
Subject: [PATCH 1/4] workflows/release-binaries: Use static ZSTD on macOS
On macOS
keith wrote:
I pushed a dummy change to that just to verify so we don't have to go back and
forth on it again. I put up the PR for the path changes here
https://github.com/llvm/llvm-project/pull/110394, I was surprised to see this
file is in the clang/ specific subdir, but also didn't see any
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/109909
>From 4676d022d971ef1623b83a2731ce94572905d6ad Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Wed, 25 Sep 2024 05:38:04 +
Subject: [PATCH 1/3] workflows/release-binaries: Use static ZSTD on macOS
On macOS
https://github.com/tstellar approved this pull request.
This looks good to me. It looks like we need to add the Release.cmake file to
the list of files that trigger the release-binaries-all test, but that can be
done in another PR.
https://github.com/llvm/llvm-project/pull/109909
@@ -126,7 +126,7 @@ jobs:
# add extra CMake args to disable them.
# See https://github.com/llvm/llvm-project/issues/99767
if [ "${{ runner.os }}" = "macOS" ]; then
- target_cmake_flags="$target_cmake_flags
-DBOOTSTRAP_COMPILER_RT_ENABLE_IOS=OFF
https://github.com/keith updated
https://github.com/llvm/llvm-project/pull/109909
>From 4676d022d971ef1623b83a2731ce94572905d6ad Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Wed, 25 Sep 2024 05:38:04 +
Subject: [PATCH 1/2] workflows/release-binaries: Use static ZSTD on macOS
On macOS
21 matches
Mail list logo
