[clang] [llvm] security check cookie execute only when needed (PR #95904)

mahesh-attarde wrote: @RKSimon @asl can you help with review or reviewers for stack protector in x86? https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [llvm] security check cookie execute only when needed (PR #95904)

mahesh-attarde wrote: > @efriedma-quic do you have any more comments? ping @efriedma-quic https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] security check cookie execute only when needed (PR #95904)

mahesh-attarde wrote: @phoebewang My current PR is MachineFunctionPass, this addressed limitations of SelectionDAG based approach. https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] security check cookie execute only when needed (PR #95904)

mahesh-attarde wrote: @efriedma-quic do you have any more comments? https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] security check cookie execute only when needed (PR #95904)

https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/95904 >From 6d6619f8f7a37906ac45791487a4d63b51a48ad1 Mon Sep 17 00:00:00 2001 From: mahesh-attarde Date: Wed, 12 Jun 2024 06:15:51 -0700 Subject: [PATCH 1/5] added regcall strct by reg support --- clang/lib/Co

[clang] [llvm] security check cookie execute only when needed (PR #95904)

@@ -97,9 +102,13 @@ define void @test_vla(i32 %n) nounwind ssp { ; MSVC-X64: callq escape ; MSVC-X64: movq [[SLOT]](%rbp), %rcx ; MSVC-X64: xorq %rbp, %rcx -; MSVC-X64: callq __security_check_cookie +; MSVC-X64:movq__security_cookie(%rip), %rax mahesh-a

[clang] [llvm] security check cookie execute only when needed (PR #95904)

@@ -5,9 +5,20 @@ declare void @h(ptr, i64, ptr) mahesh-attarde wrote: done https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [llvm] security check cookie execute only when needed (PR #95904)

https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/95904 >From 6d6619f8f7a37906ac45791487a4d63b51a48ad1 Mon Sep 17 00:00:00 2001 From: mahesh-attarde Date: Wed, 12 Jun 2024 06:15:51 -0700 Subject: [PATCH 1/4] added regcall strct by reg support --- clang/lib/Co

[clang] [llvm] security check cookie execute only when needed (PR #95904)

https://github.com/mahesh-attarde deleted https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] security check cookie execute only when needed (PR #95904)

@@ -97,9 +102,13 @@ define void @test_vla(i32 %n) nounwind ssp { ; MSVC-X64: callq escape ; MSVC-X64: movq [[SLOT]](%rbp), %rcx ; MSVC-X64: xorq %rbp, %rcx -; MSVC-X64: callq __security_check_cookie +; MSVC-X64:movq__security_cookie(%rip), %rax mahesh-a

[clang] [llvm] security check cookie execute only when needed (PR #95904)

@@ -97,9 +102,13 @@ define void @test_vla(i32 %n) nounwind ssp { ; MSVC-X64: callq escape ; MSVC-X64: movq [[SLOT]](%rbp), %rcx ; MSVC-X64: xorq %rbp, %rcx -; MSVC-X64: callq __security_check_cookie +; MSVC-X64:movq__security_cookie(%rip), %rax efriedma

[clang] [llvm] security check cookie execute only when needed (PR #95904)

@@ -5,9 +5,20 @@ declare void @h(ptr, i64, ptr) efriedma-quic wrote: Can we use update_llc_test_checks.py for this test? https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [llvm] security check cookie execute only when needed (PR #95904)

mahesh-attarde wrote: PR not related to targets other than X86_64_windows MC/AMDGPU/hsa-sym-expr-failure.s Failure seems unrelated https://github.com/llvm/llvm-project/pull/95904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [llvm] security check cookie execute only when needed (PR #95904)

https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/95904 >From 6d6619f8f7a37906ac45791487a4d63b51a48ad1 Mon Sep 17 00:00:00 2001 From: mahesh-attarde Date: Wed, 12 Jun 2024 06:15:51 -0700 Subject: [PATCH 1/3] added regcall strct by reg support --- clang/lib/Co

[clang] [llvm] security check cookie execute only when needed (PR #95904)

llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang-codegen Author: None (mahesh-attarde) Changes For windows __security_check_cookie call gets call everytime function is return without fixup. Since this function is defined in runtime library, it incures cost of call

[clang] [llvm] security check cookie execute only when needed (PR #95904)

https://github.com/mahesh-attarde created https://github.com/llvm/llvm-project/pull/95904 For windows __security_check_cookie call gets call everytime function is return without fixup. Since this function is defined in runtime library, it incures cost of call in dll which simply does comparison